Skip to content

Conversation

@Sergio0694
Copy link
Member

This fixes the Roslyn 5.0 analyzer not actually being packed.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug analyzer 👓 A new analyzer being implemented or updated labels Jan 12, 2026
Changed the source generator reference for Roslyn 5.0 to use the Roslyn5000 projects instead of Roslyn4120, ensuring the correct analyzer DLL is packaged for Roslyn 5.0.
@Sergio0694 Sergio0694 force-pushed the dev/fix-roslyn5.0-packing branch from 04ccb0f to d395f9f Compare January 13, 2026 19:08
@Sergio0694 Sergio0694 merged commit 52ef125 into main Jan 13, 2026
11 of 13 checks passed
@Sergio0694 Sergio0694 deleted the dev/fix-roslyn5.0-packing branch January 13, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analyzer 👓 A new analyzer being implemented or updated bugfix 🔧 PRs fixing a discovered bug mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant