-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unblock DataTable on Uno #496
Conversation
@dotnet-policy-service agree |
Thanks @Martin1994. But yeah, I was trying to explicitly not have an extra layer/type here and just use the natural container found in these scenarios. I believe the Uno folks are working on the issue though with ItemsPresenter? Maybe @MartinZikmund can give an update? |
That's great! If header won't be a blocker, shall we take a look at the change at column resize handler?
When a manipulation event is sent on Uno, I don't see |
@michael-hawker @Martin1994 On our side @ramezgerges is now working on adding Header and Footer support here unoplatform/uno#13507 |
Looks like the PR was merged and the issue closed: unoplatform/uno#10745 Once @Arlodotexe gets Labs up-to-date with our latest changes from the Windows/tooling repos, then we can try the latest Uno version and see how things work with DataTable |
@MartinZikmund You mentioned that this should be fixed under the latest Uno package? If I understand, we won't require the changes in this PR if the package is updated, right? |
@Arlodotexe yes, changes to the PR should not be needed |
Great, thanks @MartinZikmund! Did some testing, looks like DataTable still has a few issues to resolve. I've moved tracking here. |
This PR unblocks using DataTable on Uno with a Release build.
The top issue for now is the lack of ListView header in Uno: unoplatform/uno#1979, so this patch introduced a new container without use of a header to unblock its usage on Uno.
This approach is kinda hacky though, so I am looking for discussion about the long term direction assuming ListView's header won't be implemented in Uno soon.
Tested with WinUI 3 and Uno on Skia (WPF and GTK).