Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TransitionHelper] CancellationTokenSource is disposable and needs handling for clean-up #407

Open
michael-hawker opened this issue Mar 14, 2023 · 1 comment
Open

[TransitionHelper] CancellationTokenSource is disposable and needs handling for clean-up #407

michael-hawker opened this issue Mar 14, 2023 · 1 comment
Labels
experiment 🧪 Used to track issues that are experiments (or their linked discussions) issue 🧪 Used for tracking an Issue/Bug/Feature of an open Experiment/Component

Comments

@michael-hawker
Copy link
Member

Issue with an inner disposable reference that needs to be cleaned up by the parent class to avoid the C# compiler warning:

 D:\a\Labs-Windows\Labs-Windows\components\TransitionHelper\src\TransitionHelper.Animation.cs(30,29): error CA1001: Type 'TransitionHelper' owns disposable field(s) '_currentAnimationCancellationTokenSource' but is not disposable [D:\a\Labs-Windows\Labs-Windows\components\TransitionHelper\src\CommunityToolkit.Labs.WinUI.TransitionHelper.csproj]

For now this is ignored. Not sure how we want to handle this as it is a resourced helper...

Originally posted by @michael-hawker in #354 (comment)
@michael-hawker michael-hawker added experiment 🧪 Used to track issues that are experiments (or their linked discussions) issue 🧪 Used for tracking an Issue/Bug/Feature of an open Experiment/Component labels Mar 14, 2023
@michael-hawker
Copy link
Member Author

FYI @JustinXinLiu @Sergio0694 something that came up during porting. Don't think this is a big concern, but something we should understand and address in the future maybe?

michael-hawker added a commit to michael-hawker/Labs-Windows that referenced this issue Mar 14, 2023
@michael-hawker
Disable warning for CA1001 with disposible in TransitionHelper
9b60883 
See CommunityToolkit#407
michael-hawker added a commit to michael-hawker/Labs-Windows that referenced this issue Mar 28, 2023
@michael-hawker
Disable warning for CA1001 with disposible in TransitionHelper
0b0e1fd 
See CommunityToolkit#407
michael-hawker added a commit to michael-hawker/Labs-Windows that referenced this issue Mar 28, 2023
@michael-hawker
Disable warning for CA1001 with disposible in TransitionHelper
9fc3ca8 
See CommunityToolkit#407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
experiment 🧪 Used to track issues that are experiments (or their linked discussions) issue 🧪 Used for tracking an Issue/Bug/Feature of an open Experiment/Component
Projects
Toolkit 8.x
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michael-hawker