feat: add node translation editor for i18n management #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a comprehensive node translation editor feature that enables authenticated users to manage translations for ComfyUI custom nodes. The implementation provides a user-friendly interface for translating node metadata into multiple supported languages with dynamic field management capabilities.
- Adds new translation editor page at
/nodes/[nodeId]/i18nwith authentication protection - Implements comprehensive Storybook stories covering various states (loading, errors, existing translations)
- Provides detailed documentation explaining the feature's functionality and technical implementation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pages/nodes/[nodeId]/i18n.tsx | Main translation editor component with language selection, field management, and save functionality |
| src/stories/pages/NodeTranslationEditor.stories.tsx | Comprehensive Storybook stories demonstrating different editor states and scenarios |
| docs/node-translation-editor.md | Complete feature documentation covering usage, technical implementation, and API integration |
snomiao
force-pushed
the
sno-translation-edit
branch
from
00cf1de to
c01659f
Compare
- Add /nodes/[nodeId]/i18n page for editing node translations - Implement translation interface with language selection and field editing - Support for adding custom translation fields beyond default ones - Include comprehensive error handling and success feedback - Add Storybook stories with various scenarios and mock data - Document feature implementation and usage in docs/ 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
… rendering to proper type
- Add /nodes/[nodeId]/i18n page for editing node translations - Implement translation interface with language selection and field editing - Support for adding custom translation fields beyond default ones - Include comprehensive error handling and success feedback - Add Storybook stories with various scenarios and mock data - Document feature implementation and usage in docs/ 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
… rendering to proper type
snomiao
force-pushed
the
sno-translation-edit
branch
from
c01659f to
2763261
Compare
Added translation management functionality for custom nodes: - New translation editor pages at /nodes/[nodeId]/i18n and /nodes/[nodeId]/translations - Edit translations button in NodeDetails component - Support for multi-language node metadata editing - Language selection with native and localized names - Field-based translation editing with add/remove capabilities 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Updated NodeTranslationEditor stories to include permission endpoint mocks, ensuring stories render correctly with edit permissions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Extract DEFAULT_FIELDS constant to reduce duplication - Extract SUCCESS_MESSAGE_TIMEOUT_MS constant for hardcoded timeout - Replace type assertions with String() conversion for better type safety - Apply Biome formatter fixes to multiple files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add explicit return types for getCurrentTranslations function - Extract DEFAULT_FIELDS and SUCCESS_MESSAGE_TIMEOUT_MS constants - Create getFieldValue helper to properly handle string|string[] types - Remove unsafe type assertions and use type-safe value extraction - Address Copilot review comments for better type safety - Merge with latest main branch and resolve conflicts - Move Storybook files to new component-colocated structure - Update translation files with new keys for all supported languages 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Resolved conflicts in: - README.md: updated workflow documentation formatting - components/nodes/NodeDetails.tsx: removed translation edit functionality - components/publisher/CreatePublisherModal.tsx: updated to use CreatePublisherFormContent - docs/update-pr-branches.md: fixed formatting inconsistencies - pages/publishers/create.tsx: updated to use CreatePublisherFormContent - src/constants.ts: kept LANGUAGE_NAMES as exported constant - utils/comfyTheme.tsx: maintained consistent modal theming 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/nodes/[nodeId]/i18nfor editing node translationsTest plan
🤖 Generated with Claude Code