-
Notifications
You must be signed in to change notification settings - Fork 410
[feat] Add CI checks for OSS license compliance and telemetry tree-shaking #6777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…aking Implements automated verification to ensure the OSS distribution: 1. Only includes open-source licensed dependencies 2. Properly tree-shakes proprietary fonts (ABCROM) 3. Removes telemetry code (Mixpanel) from OSS builds New scripts: - scripts/verify-licenses.js - Validates production dependency licenses - scripts/verify-oss-build.js - Checks dist/ for violations New CI workflow: - .github/workflows/ci-oss-compliance.yaml - Runs compliance checks New npm scripts: - pnpm verify:licenses - Check dependency licenses - pnpm verify:oss - Verify OSS build compliance - pnpm verify:compliance - Run all checks - pnpm build:oss - Build OSS distribution Documentation: - docs/OSS_COMPLIANCE.md - Complete guide for compliance checks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/20/2025, 06:15:27 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/20/2025, 06:25:55 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.13 MB (baseline 3.13 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 945 kB (baseline 945 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 7.97 kB (baseline 7.97 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 306 kB (baseline 306 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 141 kB (baseline 141 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BBundles that do not match a named category
|
Summary
Implements automated verification to ensure the OSS distribution complies with licensing requirements and properly removes proprietary/telemetry code.
This PR addresses the requirements from the Notion task:
Changes
New Verification Scripts
scripts/verify-licenses.jsscripts/verify-oss-build.jsdist/directory for violationsCI Workflow
.github/workflows/ci-oss-compliance.yamllicense-check: Verifies dependency licensesoss-build-check: Builds OSS distribution and verifies complianceNPM Scripts
Documentation
docs/OSS_COMPLIANCE.mdHow It Works
Tree-Shaking Mechanism
The build uses compile-time constants for dead code elimination:
When building with
DISTRIBUTION=localhost:isCloudevaluates tofalseVerification Patterns
The OSS build verifier checks for:
Proprietary Fonts:
.woff,.woff2,.ttf,.otffiles containing "ABCROM"Telemetry Code:
mixpanel/MixpanelTelemetryProvidertrackWorkflow,trackEvent,.track(mp.comfy.orgTest Plan
Testing Locally
Notes
🤖 Generated with Claude Code
Fixes #10204
┆Issue is synchronized with this Notion page by Unito