refactor: move core graph modules into workbench layer #6689
+70
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 11/14/2025, 01:20:24 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/14/2025, 01:10:28 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 2.94 MB (baseline 2.94 MB) • 🔴 +734 BMain entry bundles and manifests
Status: 4 added / 4 removed Graph Workspace — 799 kB (baseline 799 kB) • 🔴 +50 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8 kB (baseline 8 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 306 kB (baseline 306 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 266 kB (baseline 266 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 5.87 kB (baseline 5.87 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.92 MB (baseline 3.92 MB) • ⚪ 0 BBundles that do not match a named category
Status: 15 added / 15 removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (pre-refactor)
useCoreCommands→core/graph/subgraph/proxyWidgetUtils→ renderer stores/services → renderer chunks loaded even for workbench-only consumers.src/core/**imported Pinia stores (domWidgetStore,subgraphNavigationStore) and renderer canvas stores.After (current state)
src/renderer/**.litegraphServicemaintains optional renderer handlers. Workbench code consumes stable APIs instead of importing renderer modules or using dynamicimport().useCoreCommands→litegraphService.invokeToggleWidgetPromotion()→ renderer handler (if registered)litegraphServicecontext menu hook →widgetPromotionHandlers.addWidgetPromotionOptionsscripts/app(renderer bootstrap) still imports the renderer module directly, which is acceptable for full renderer entrypoints.┆Issue is synchronized with this Notion page by Unito