feat: Add cloud E2E testing infrastructure #6625
Conversation
Adds Playwright tests for cloud environment with Firebase auth. Changes: - Refactor ComfyPage to abstract base class - Add LocalhostComfyPage (existing devtools implementation) - Add CloudComfyPage (cloud settings API, Firebase auth) - Add cloud fixture with auth state persistence - Add globalSetupCloud for Firebase login - Add playwright.cloud.config with 5x timeout - Add basic cloud tests (load app, canvas interaction, settings) - Update .gitignore for auth state files - Update tsconfig to include playwright.cloud.config Architecture: - ComfyPage abstract with 3 backend-specific methods - LocalhostComfyPage uses /api/devtools + multi-user - CloudComfyPage uses /api/settings + Firebase localStorage - No code duplication (95% shared) Setup: - Requires CLOUD_TEST_EMAIL and CLOUD_TEST_PASSWORD env vars - globalSetup logs in once, saves auth to browser_tests/.auth/ - Tests reuse saved auth state (no login per test)
dosubot
bot
added
the
size:L
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/16/2025, 07:53:02 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/16/2025, 08:02:59 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 2.98 MB (baseline 2.98 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 803 kB (baseline 803 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 8.03 kB (baseline 8.03 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 307 kB (baseline 307 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 210 kB (baseline 210 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 5.87 kB (baseline 5.87 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.92 MB (baseline 3.92 MB) • ⚪ 0 BBundles that do not match a named category
|
Fixes circular dependency between ComfyPage and LocalhostComfyPage. Changes: - Create browser_tests/fixtures/comfyPageFixture.ts with fixture - Remove fixture from ComfyPage.ts (keep abstract class only) - Re-export fixture from ComfyPage.ts for backward compatibility Now properly follows dependency hierarchy: - ComfyPage.ts (abstract) - no implementation imports - LocalhostComfyPage.ts → imports ComfyPage - comfyPageFixture.ts → imports both - Tests import from ComfyPage.ts (re-exported)
Circular dependency was caused by: - comfyPageFixture.ts importing testComfySnapToGridGridSize from ComfyPage.ts - ComfyPage.ts re-exporting comfyPageFixture Solution: - Extract testComfySnapToGridGridSize to constants.ts - Both files import from constants.ts - Only type-import ComfyPage in comfyPageFixture.ts Now clean dependency graph with no cycles.
- Remove comfyPageFixture re-export from ComfyPage.ts - Update all test imports to use comfyPageFixture from its own file - Update README.md example to show correct import path - Fixes: comfyPageFixture → LocalhostComfyPage → ComfyPage circular import
…t.config.ts to tsconfig
- Create ci-tests-e2e-cloud.yaml workflow - Manual trigger via workflow_dispatch - Uses CLOUD_TEST_EMAIL and CLOUD_TEST_PASSWORD secrets - Add CLOUD_TESTS.md documentation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Summary
Adds Playwright tests for cloud with Firebase auth.
Changes
Setup
Requires env vars:
Run
Goal
Validate approach before expanding coverage or adding CI.
┆Issue is synchronized with this Notion page by Unito