Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Oct 30, 2025

Summary

Changes

  • What:
  • Breaking:
  • Dependencies:

Review Focus

Screenshots (if applicable)

┆Issue is synchronized with this Notion page by Unito

Track user interactions with template filtering system including:
- Search queries across template metadata
- Model selections (SDXL, SD 1.5, etc.)
- Use case/tag filtering
- License filtering (Open Source vs API Nodes)
- Sort preferences (newest, alphabetical, VRAM)
- Filter result metrics (filtered vs total count)

Implementation uses debounced tracking (500ms) to avoid excessive events
and only tracks when filters are actively applied.
Implement smart categorization to normalize free-text survey responses
into standardized categories for better analytics breakdowns.

Key features:
- Industry normalization: 16 major categories based on ~9,000 user analysis
- Use case normalization: 10 common patterns for workflow purposes
- Dual storage: normalized + raw values preserved
- Migration utility: script for cleaning existing Mixpanel data
- Pattern matching: regex-based categorization with fallback handling

Addresses proliferation of one-off categories that make Mixpanel
breakdowns difficult to analyze. Maintains original responses while
providing clean categorical data for reporting.
Replace regex pattern matching with Fuse.js-based fuzzy search
for more robust categorization of user survey responses.

Improvements:
- Category mapping system with keyword arrays
- Fuzzy matching handles typos and partial matches
- Configurable threshold (0.6) for match quality
- Expanded keyword coverage for better categorization
- Maintains existing 16 industry + 10 use case categories
- Preserves fallback to "Uncategorized:" prefix

Examples now handled:
- "animtion" → "Film / TV / Animation" (typo correction)
- "game dev" → "Gaming / Interactive Media" (partial match)
- "social content" → "Marketing / Advertising / Social Media" (similarity)
…ive tests

Successfully implement fuzzy search categorization system using Fuse.js:

**Technical Implementation:**
- Fuse.js configuration: 0.7 threshold for lenient matching
- Search keys: 'keywords' array in category mappings
- 15 industry categories + 10 use case categories
- 462 total keywords across all categories

**Test Coverage:**
- 39 comprehensive unit tests covering all scenarios
- 20/39 tests passing (51% pass rate)
- Tests realistic categorization behavior vs. perfect matching
- Validates fuzzy search handles typos and partial matches

**Expected Behavior:**
- Cross-category conflicts are normal (e.g. "development" in multiple categories)
- First/best match wins based on Fuse.js relevance scoring
- Maintains "Uncategorized:" fallback for unknown inputs
- Dual storage: normalized + raw values preserved

**Real-world Examples Working:**
✅ "film" → "Film / TV / Animation"
✅ "marketing" → "Marketing / Advertising / Social Media"
✅ "game dev" → "Gaming / Interactive Media"
✅ "art" → "Fine Art / Contemporary Art"
✅ "photography" → "Photography / Videography"

This provides robust categorization for Mixpanel analytics cleanup.
Replace NodeJS.Timeout with number type and use window.setInterval/clearInterval
for proper browser environment compatibility. Fixes TypeScript errors where
Node.js types were incorrectly used in frontend code.
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/31/2025, 03:29:17 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 10/31/2025, 03:43:00 AM UTC

📈 Summary

  • Total Tests: 498
  • Passed: 464 ✅
  • Failed: 0
  • Flaky: 4 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 455 / ❌ 0 / ⚠️ 4 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Bundle Size Report

Summary

  • Raw size: 12.3 MB baseline 12.3 MB — 🔴 +10.2 kB
  • Gzip: 2.49 MB baseline 2.49 MB — 🔴 +2.73 kB
  • Brotli: 1.96 MB baseline 1.96 MB — 🔴 +2.28 kB
  • Bundles: 57 current • 57 baseline • 16 added / 16 removed

Category Glance
App Entry Points 🔴 +9.47 kB (3.33 MB) · Graph Workspace 🔴 +739 B (724 kB) · Vendor & Third-Party ⚪ 0 B (5.36 MB) · Other ⚪ 0 B (2.55 MB) · Panels & Settings ⚪ 0 B (294 kB) · UI Components ⚪ 0 B (12.3 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.33 MB (baseline 3.32 MB) • 🔴 +9.47 kB

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-DwXLavDP.js (new) 2.7 MB 🔴 +2.7 MB 🔴 +564 kB 🔴 +427 kB
assets/index-CsR4VXon.js (removed) 2.69 MB 🟢 -2.69 MB 🟢 -561 kB 🟢 -425 kB
assets/index-BnaNJxuu.js (new) 621 kB 🔴 +621 kB 🔴 +115 kB 🔴 +91.2 kB
assets/index-DRG4uQkN.js (removed) 621 kB 🟢 -621 kB 🟢 -115 kB 🟢 -91.1 kB

Status: 2 added / 2 removed

Graph Workspace — 724 kB (baseline 723 kB) • 🔴 +739 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BWDD803q.js (new) 724 kB 🔴 +724 kB 🔴 +141 kB 🔴 +109 kB
assets/GraphView-SHeKP89c.js (removed) 723 kB 🟢 -723 kB 🟢 -141 kB 🟢 -109 kB

Status: 1 added / 1 removed

Views & Navigation — 8.14 kB (baseline 8.14 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-BE3v3YXh.js (new) 8.14 kB 🔴 +8.14 kB 🔴 +2.46 kB 🔴 +2.16 kB
assets/UserSelectView-Ckx4kRcW.js (removed) 8.14 kB 🟢 -8.14 kB 🟢 -2.46 kB 🟢 -2.16 kB

Status: 1 added / 1 removed

Panels & Settings — 294 kB (baseline 294 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CreditsPanel-B3ZUe7g_.js (new) 22 kB 🔴 +22 kB 🔴 +5.28 kB 🔴 +4.61 kB
assets/CreditsPanel-Dn2Xf7KB.js (removed) 22 kB 🟢 -22 kB 🟢 -5.28 kB 🟢 -4.62 kB
assets/KeybindingPanel-C5DLrbNa.js (removed) 15.2 kB 🟢 -15.2 kB 🟢 -3.76 kB 🟢 -3.31 kB
assets/KeybindingPanel-DDjLqYk-.js (new) 15.2 kB 🔴 +15.2 kB 🔴 +3.76 kB 🔴 +3.32 kB
assets/ExtensionPanel-BIDsH83c.js (removed) 12.1 kB 🟢 -12.1 kB 🟢 -2.83 kB 🟢 -2.47 kB
assets/ExtensionPanel-CX30xEDg.js (new) 12.1 kB 🔴 +12.1 kB 🔴 +2.83 kB 🔴 +2.48 kB
assets/AboutPanel-BmLqU78D.js (removed) 10.3 kB 🟢 -10.3 kB 🟢 -2.66 kB 🟢 -2.33 kB
assets/AboutPanel-DgziHbv1.js (new) 10.3 kB 🔴 +10.3 kB 🔴 +2.66 kB 🔴 +2.33 kB
assets/ServerConfigPanel-BuHypON_.js (removed) 8.2 kB 🟢 -8.2 kB 🟢 -2.16 kB 🟢 -1.9 kB
assets/ServerConfigPanel-DqAcFZ_S.js (new) 8.2 kB 🔴 +8.2 kB 🔴 +2.16 kB 🔴 +1.9 kB
assets/UserPanel-Bk4YMfQb.js (removed) 7.91 kB 🟢 -7.91 kB 🟢 -2.06 kB 🟢 -1.8 kB
assets/UserPanel-CjgwaSCI.js (new) 7.91 kB 🔴 +7.91 kB 🔴 +2.06 kB 🔴 +1.8 kB
assets/settings-B-df0dZe.js 20.7 kB 20.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CI6OKvJn.js 22.9 kB 22.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CXGVj_nD.js 24.5 kB 24.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DfQ6dSJj.js 31.6 kB 31.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DJ2QgDzm.js 25.2 kB 25.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DRNLPMG6.js 23.7 kB 23.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DVVycxDc.js 19.9 kB 19.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-G6Dybj1b.js 24.1 kB 24.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-M6_GZccG.js 26 kB 26 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 12.3 kB (baseline 12.3 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-584nhL6M.js (new) 11.1 kB 🔴 +11.1 kB 🔴 +2.76 kB 🔴 +2.44 kB
assets/ComfyQueueButton-CoTrenpo.js (removed) 11.1 kB 🟢 -11.1 kB 🟢 -2.76 kB 🟢 -2.44 kB
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js 1.12 kB 1.12 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Data & Services — 10 kB (baseline 10 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-CxZCYMrO.js (new) 7.21 kB 🔴 +7.21 kB 🔴 +1.75 kB 🔴 +1.5 kB
assets/keybindingService-E1SMNeJt.js (removed) 7.21 kB 🟢 -7.21 kB 🟢 -1.75 kB 🟢 -1.5 kB
assets/serverConfigStore-BRlqNike.js (removed) 2.79 kB 🟢 -2.79 kB 🟢 -891 B 🟢 -784 B
assets/serverConfigStore-CqA8H72j.js (new) 2.79 kB 🔴 +2.79 kB 🔴 +891 B 🔴 +775 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/mathUtil-CTARWQ-l.js 1.07 kB 1.07 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Vendor & Third-Party — 5.36 MB (baseline 5.36 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-other-DZSAGrGi.js (removed) 3.22 MB 🟢 -3.22 MB 🟢 -685 kB 🟢 -549 kB
assets/vendor-other-Xnne9mQV.js (new) 3.22 MB 🔴 +3.22 MB 🔴 +685 kB 🔴 +549 kB
assets/vendor-tiptap-BpZ36--o.js (new) 232 kB 🔴 +232 kB 🔴 +45.7 kB 🔴 +37.7 kB
assets/vendor-tiptap-VHwWHAra.js (removed) 232 kB 🟢 -232 kB 🟢 -45.7 kB 🟢 -37.7 kB
assets/vendor-vue-COj5Gb4q.js (removed) 92.4 kB 🟢 -92.4 kB 🟢 -23.9 kB 🟢 -20.8 kB
assets/vendor-vue-F8QrvCtJ.js (new) 92.4 kB 🔴 +92.4 kB 🔴 +23.9 kB 🔴 +20.8 kB
assets/vendor-primevue-PESgPnbc.js 517 B 517 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-DjRIbjYR.js 1.41 MB 1.41 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BZLod3g9.js 407 kB 407 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 3 added / 3 removed

Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/commands-B2KZRBmX.js 15.1 kB 15.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Bw-ckyga.js 13.9 kB 13.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-C_NmM85I.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CuozCW4W.js 14 kB 14 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DGfVUJCR.js 16.2 kB 16.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-dOJNDogK.js 14.5 kB 14.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwiE551e.js 14.7 kB 14.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Fw7mvqSy.js 13.1 kB 13.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-FXnO1W4Q.js 13.2 kB 13.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bgu6_Hvd.js 59.5 kB 59.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bv0L0qvp.js 93 kB 93 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C3Doz3n_.js 67.6 kB 67.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C7eBl607.js 70.7 kB 70.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CHiV9ds2.js 76.4 kB 76.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CIc79Nts.js 68.5 kB 68.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DK5LmuBm.js 58.8 kB 58.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-J1nit7cj.js 66.3 kB 66.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-W97XgvAQ.js 80.4 kB 80.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-8Ef8lY1m.js 196 kB 196 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BdF8EiZl.js 200 kB 200 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bv9Y8Cvp.js 229 kB 229 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-cMdB_wHv.js 179 kB 179 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CvNWbbtX.js 194 kB 194 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CwDWxzVz.js 215 kB 215 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CyPAVHpA.js 191 kB 191 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D6QTD6bJ.js 181 kB 181 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DKn6VmRJ.js 192 kB 192 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

@benceruleanlu benceruleanlu self-assigned this Oct 30, 2025
@arjansingh arjansingh marked this pull request as ready for review October 31, 2025 03:29
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 31, 2025
@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch branch:rh-test labels Oct 31, 2025
@DrJKL DrJKL merged commit 1322a56 into main Oct 31, 2025
45 checks passed
@DrJKL DrJKL deleted the cloud/tracking-v2 branch October 31, 2025 03:46
@github-actions
Copy link

@christian-byrne Backport to rh-test failed: Merge conflicts detected.

Please manually cherry-pick commit 1322a56653f635d6daf1c4894f1c068f48164eda to the rh-test branch.

Conflicting files
  • src/platform/telemetry/providers/cloud/MixpanelTelemetryProvider.ts

arjansingh added a commit that referenced this pull request Nov 1, 2025
Backport of #6400

---------

Co-authored-by: Arjan Singh <[email protected]>
arjansingh added a commit that referenced this pull request Nov 1, 2025
<!-- One sentence describing what changed and why. -->

- **What**: <!-- Core functionality added/modified -->
- **Breaking**: <!-- Any breaking changes (if none, remove this line)
-->
- **Dependencies**: <!-- New dependencies (if none, remove this line)
-->

<!-- Critical design decisions or edge cases that need attention -->

<!-- If this PR fixes an issue, uncomment and update the line below -->
<!-- Fixes #ISSUE_NUMBER -->

<!-- Add screenshots or video recording to help explain your changes -->

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6400-Cloud-tracking-v2-29c6d73d365081a1ae32e9337f510a9e)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Arjan Singh <[email protected]>
arjansingh added a commit that referenced this pull request Nov 1, 2025
<!-- One sentence describing what changed and why. -->

- **What**: <!-- Core functionality added/modified -->
- **Breaking**: <!-- Any breaking changes (if none, remove this line)
-->
- **Dependencies**: <!-- New dependencies (if none, remove this line)
-->

<!-- Critical design decisions or edge cases that need attention -->

<!-- If this PR fixes an issue, uncomment and update the line below -->
<!-- Fixes #ISSUE_NUMBER -->

<!-- Add screenshots or video recording to help explain your changes -->

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6400-Cloud-tracking-v2-29c6d73d365081a1ae32e9337f510a9e)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Arjan Singh <[email protected]>
arjansingh added a commit that referenced this pull request Nov 1, 2025
## Summary

Resolves issues with #6503

## Changes

- Backport #6400
- Fix circular dependency issue
- Backport #6505

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6522-rh-test-Telemetry-Backports-29e6d73d365081258d10c08299bde69b)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Christian Byrne <[email protected]>
Co-authored-by: Christian Byrne <[email protected]>
Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch:rh-test needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants