Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Oct 30, 2025

Summary

Gate the Top up buttons in the user dropdown and credits page of the settings.

┆Issue is synchronized with this Notion page by Unito

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 11/01/2025, 08:06:30 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 11/01/2025, 08:20:22 AM UTC

📈 Summary

  • Total Tests: 498
  • Passed: 464 ✅
  • Failed: 0
  • Flaky: 4 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 455 / ❌ 0 / ⚠️ 4 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Bundle Size Report

Summary

  • Raw size: 12.2 MB baseline 12.2 MB — 🔴 +434 B
  • Gzip: 2.48 MB baseline 2.48 MB — 🟢 -261 B
  • Brotli: 1.95 MB baseline 1.95 MB — 🟢 -240 B
  • Bundles: 57 current • 57 baseline • 16 added / 16 removed

Category Glance
App Entry Points 🔴 +5.36 kB (3.27 MB) · Graph Workspace 🟢 -5.07 kB (723 kB) · Panels & Settings 🔴 +141 B (295 kB) · Vendor & Third-Party ⚪ 0 B (5.32 MB) · Other ⚪ 0 B (2.55 MB) · UI Components ⚪ 0 B (12.3 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.27 MB (baseline 3.27 MB) • 🔴 +5.36 kB

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-BFA_bRaW.js (new) 2.89 MB 🔴 +2.89 MB 🔴 +596 kB 🔴 +450 kB
assets/index-CqyOi4nD.js (removed) 2.88 MB 🟢 -2.88 MB 🟢 -595 kB 🟢 -449 kB
assets/index-DEoox687.js (new) 381 kB 🔴 +381 kB 🔴 +76.6 kB 🔴 +62.1 kB
assets/index-CL2U1TN6.js (removed) 381 kB 🟢 -381 kB 🟢 -76.6 kB 🟢 -62.1 kB

Status: 2 added / 2 removed

Graph Workspace — 723 kB (baseline 728 kB) • 🟢 -5.07 kB

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-Da_-3G8M.js (removed) 728 kB 🟢 -728 kB 🟢 -142 kB 🟢 -110 kB
assets/GraphView-rXrmcN1s.js (new) 723 kB 🔴 +723 kB 🔴 +141 kB 🔴 +109 kB

Status: 1 added / 1 removed

Views & Navigation — 8.18 kB (baseline 8.18 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-4gq40-XR.js (removed) 8.18 kB 🟢 -8.18 kB 🟢 -2.48 kB 🟢 -2.18 kB
assets/UserSelectView-BDBN4mur.js (new) 8.18 kB 🔴 +8.18 kB 🔴 +2.48 kB 🔴 +2.17 kB

Status: 1 added / 1 removed

Panels & Settings — 295 kB (baseline 295 kB) • 🔴 +141 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CreditsPanel-4G7MH9uA.js (new) 22.2 kB 🔴 +22.2 kB 🔴 +5.33 kB 🔴 +4.66 kB
assets/CreditsPanel-D2TuRvE0.js (removed) 22.1 kB 🟢 -22.1 kB 🟢 -5.29 kB 🟢 -4.63 kB
assets/KeybindingPanel-BVrFIRom.js (new) 15.3 kB 🔴 +15.3 kB 🔴 +3.78 kB 🔴 +3.33 kB
assets/KeybindingPanel-DDSaI2yS.js (removed) 15.3 kB 🟢 -15.3 kB 🟢 -3.78 kB 🟢 -3.33 kB
assets/ExtensionPanel-BNAVyJRg.js (removed) 12.1 kB 🟢 -12.1 kB 🟢 -2.84 kB 🟢 -2.49 kB
assets/ExtensionPanel-BT2dNff1.js (new) 12.1 kB 🔴 +12.1 kB 🔴 +2.84 kB 🔴 +2.48 kB
assets/AboutPanel-BmGqp1eC.js (removed) 10.3 kB 🟢 -10.3 kB 🟢 -2.68 kB 🟢 -2.34 kB
assets/AboutPanel-DTKFUj40.js (new) 10.3 kB 🔴 +10.3 kB 🔴 +2.68 kB 🔴 +2.34 kB
assets/ServerConfigPanel-CbNB4X_J.js (new) 8.23 kB 🔴 +8.23 kB 🔴 +2.18 kB 🔴 +1.91 kB
assets/ServerConfigPanel-SnZwmBzI.js (removed) 8.23 kB 🟢 -8.23 kB 🟢 -2.18 kB 🟢 -1.92 kB
assets/UserPanel-CCdli-YR.js (removed) 7.94 kB 🟢 -7.94 kB 🟢 -2.07 kB 🟢 -1.8 kB
assets/UserPanel-DzlhW9-w.js (new) 7.94 kB 🔴 +7.94 kB 🔴 +2.07 kB 🔴 +1.81 kB
assets/settings-B-df0dZe.js 20.7 kB 20.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CI6OKvJn.js 22.9 kB 22.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CXGVj_nD.js 24.5 kB 24.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DfQ6dSJj.js 31.6 kB 31.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DJ2QgDzm.js 25.2 kB 25.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DRNLPMG6.js 23.7 kB 23.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DVVycxDc.js 19.9 kB 19.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-G6Dybj1b.js 24.1 kB 24.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-M6_GZccG.js 26 kB 26 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 12.3 kB (baseline 12.3 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-7zl7fIUm.js (new) 11.2 kB 🔴 +11.2 kB 🔴 +2.77 kB 🔴 +2.45 kB
assets/ComfyQueueButton-D16J8TER.js (removed) 11.2 kB 🟢 -11.2 kB 🟢 -2.77 kB 🟢 -2.45 kB
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js 1.12 kB 1.12 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Data & Services — 10 kB (baseline 10 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-D9FMt523.js (removed) 7.21 kB 🟢 -7.21 kB 🟢 -1.75 kB 🟢 -1.5 kB
assets/keybindingService-M4aQvIlT.js (new) 7.21 kB 🔴 +7.21 kB 🔴 +1.75 kB 🔴 +1.5 kB
assets/serverConfigStore-COh79gIl.js (removed) 2.79 kB 🟢 -2.79 kB 🟢 -889 B 🟢 -782 B
assets/serverConfigStore-DirrtUFq.js (new) 2.79 kB 🔴 +2.79 kB 🔴 +890 B 🔴 +780 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/mathUtil-CTARWQ-l.js 1.07 kB 1.07 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-other-CsjOC_04.js (removed) 3.22 MB 🟢 -3.22 MB 🟢 -685 kB 🟢 -549 kB
assets/vendor-other-DXPzaR2u.js (new) 3.22 MB 🔴 +3.22 MB 🔴 +685 kB 🔴 +549 kB
assets/vendor-tiptap-D9I7d56W.js (removed) 232 kB 🟢 -232 kB 🟢 -45.7 kB 🟢 -37.7 kB
assets/vendor-tiptap-NQ2IMoC9.js (new) 232 kB 🔴 +232 kB 🔴 +45.7 kB 🔴 +37.7 kB
assets/vendor-vue-Bdhww8Wc.js (new) 92.4 kB 🔴 +92.4 kB 🔴 +23.9 kB 🔴 +20.8 kB
assets/vendor-vue-C9uUGFo-.js (removed) 92.4 kB 🟢 -92.4 kB 🟢 -23.9 kB 🟢 -20.8 kB
assets/vendor-primevue-PESgPnbc.js 517 B 517 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-JDoAqkQm.js 1.37 MB 1.37 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BZLod3g9.js 407 kB 407 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 3 added / 3 removed

Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/commands-B2KZRBmX.js 15.1 kB 15.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Bw-ckyga.js 13.9 kB 13.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-C_NmM85I.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CuozCW4W.js 14 kB 14 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DGfVUJCR.js 16.2 kB 16.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-dOJNDogK.js 14.5 kB 14.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwiE551e.js 14.7 kB 14.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Fw7mvqSy.js 13.1 kB 13.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-FXnO1W4Q.js 13.2 kB 13.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bgu6_Hvd.js 59.5 kB 59.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bv0L0qvp.js 93 kB 93 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C3Doz3n_.js 67.6 kB 67.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C7eBl607.js 70.7 kB 70.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CHiV9ds2.js 76.4 kB 76.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CIc79Nts.js 68.5 kB 68.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DK5LmuBm.js 58.8 kB 58.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-J1nit7cj.js 66.3 kB 66.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-W97XgvAQ.js 80.4 kB 80.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-8Ef8lY1m.js 196 kB 196 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BdF8EiZl.js 200 kB 200 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bv9Y8Cvp.js 229 kB 229 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-cMdB_wHv.js 179 kB 179 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CvNWbbtX.js 194 kB 194 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CwDWxzVz.js 215 kB 215 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CyPAVHpA.js 191 kB 191 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D6QTD6bJ.js 181 kB 181 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DKn6VmRJ.js 192 kB 192 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch branch:rh-test labels Oct 30, 2025
@DrJKL DrJKL force-pushed the cloud/gate-topup-on-subscription branch from 04410da to 08f8cdc Compare October 30, 2025 19:43
@DrJKL DrJKL self-assigned this Oct 30, 2025
@DrJKL DrJKL marked this pull request as ready for review October 31, 2025 01:26
@DrJKL DrJKL requested a review from pythongosssss as a code owner October 31, 2025 01:26
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 31, 2025
@DrJKL DrJKL assigned arjansingh and unassigned DrJKL Oct 31, 2025
@DrJKL DrJKL force-pushed the cloud/gate-topup-on-subscription branch from 8a402bc to b89e305 Compare October 31, 2025 01:37
DrJKL
DrJKL previously approved these changes Oct 31, 2025
viva-jinyi
viva-jinyi previously approved these changes Oct 31, 2025
Copy link
Member

@viva-jinyi viva-jinyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arjansingh
arjansingh previously approved these changes Oct 31, 2025
christian-byrne and others added 2 commits November 1, 2025 00:49
Prevent users without active subscriptions from accessing credit top-up features by checking isActiveSubscription across all entry points.

Changes:
- Hide Purchase Credits button in CreditsPanel when no active subscription
- Block purchaseCredits function execution if subscription inactive
- Gate showTopUpCreditsDialog service method
- Prevent auto-trigger of top-up dialog on insufficient credits error
- Fix CurrentUserPopover test mock for isActiveSubscription ref
@christian-byrne christian-byrne dismissed stale reviews from arjansingh, viva-jinyi, and DrJKL via b74af8d November 1, 2025 08:04
@christian-byrne christian-byrne force-pushed the cloud/gate-topup-on-subscription branch from b89e305 to b74af8d Compare November 1, 2025 08:04
@christian-byrne christian-byrne merged commit c8e2419 into main Nov 1, 2025
27 checks passed
@christian-byrne christian-byrne deleted the cloud/gate-topup-on-subscription branch November 1, 2025 08:37
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

@christian-byrne Backport to rh-test failed: Merge conflicts detected.

Please manually cherry-pick commit c8e24190cd7bf5e69bd2a3af8b5b7010738612f9 to the rh-test branch.

Conflicting files
  • src/composables/auth/useFirebaseAuthActions.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch:rh-test needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants