-
Notifications
You must be signed in to change notification settings - Fork 395
Cloud/gate topup on subscription #6399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/01/2025, 08:06:30 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/01/2025, 08:20:22 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.27 MB (baseline 3.27 MB) • 🔴 +5.36 kBMain entry bundles and manifests
Status: 2 added / 2 removed Graph Workspace — 723 kB (baseline 728 kB) • 🟢 -5.07 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.18 kB (baseline 8.18 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 295 kB (baseline 295 kB) • 🔴 +141 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 12.3 kB (baseline 12.3 kB) • ⚪ 0 BReusable component library chunks
Status: 1 added / 1 removed Data & Services — 10 kB (baseline 10 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Status: 3 added / 3 removed Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
04410da to
08f8cdc
Compare
8a402bc to
b89e305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Prevent users without active subscriptions from accessing credit top-up features by checking isActiveSubscription across all entry points. Changes: - Hide Purchase Credits button in CreditsPanel when no active subscription - Block purchaseCredits function execution if subscription inactive - Gate showTopUpCreditsDialog service method - Prevent auto-trigger of top-up dialog on insufficient credits error - Fix CurrentUserPopover test mock for isActiveSubscription ref
b74af8d
b89e305 to
b74af8d
Compare
|
@christian-byrne Backport to Please manually cherry-pick commit Conflicting files
|
Summary
Gate the Top up buttons in the user dropdown and credits page of the settings.
┆Issue is synchronized with this Notion page by Unito