Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Oct 30, 2025

Summary

Backport of PR #6378 to rh-test branch.

Changes

  • Extract credit calculations into useSubscriptionCredits composable
  • Extract action handlers into useSubscriptionActions composable
  • Add comprehensive component and unit tests
  • Update subscription panel layout to match Figma design exactly
  • Add proper design tokens for modal card surfaces
  • Update terminology from "API Nodes" to "Partner Nodes"
  • Make credit breakdown dynamic with real API data
  • Add proper loading states and error handling
  • Remove unused tailwindcss eslint dependencies

Conflicts Resolved

  • Resolved merge conflicts in packages/design-system/src/css/style.css related to button surface CSS variables

Test plan

  • Existing tests pass
  • New tests for subscription composables and components

┆Issue is synchronized with this Notion page by Unito

christian-byrne and others added 2 commits October 29, 2025 20:29
Refactoring of subscription panel to improve maintainability and match
Figma design exactly. Extracted business logic into
`useSubscriptionCredits` and `useSubscriptionActions` composables, added
comprehensive testing, and enhanced the design system with proper
semantic tokens.

- Extract credit calculations and action handlers into reusable
composables
- Add component and unit tests with proper mocking patterns
- Update terminology from "API Nodes" to "Partner Nodes"
- Make credit breakdown dynamic using real API data instead of hardcoded
values
- Add semantic design tokens for modal card surfaces with light/dark
theme support
- Reduce component complexity from ~100 lines to ~25 lines of logic
- Improve layout spacing, typography, and responsive behavior to match
Figma specs

<img width="1948" height="1494" alt="Selection_2220"
src="https://github.com/user-attachments/assets/b922582d-7edf-4884-b787-ad783c896b80"
/>

<img width="1948" height="1494" alt="Selection_2219"
src="https://github.com/user-attachments/assets/50a9f263-9adb-439d-8a89-94a498d394e3"
/>

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6378-update-subscription-panel-for-new-designs-29b6d73d3650815c9ce2c5977ac7f893)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Claude <[email protected]>
- Remove @types/eslint-plugin-tailwindcss
- Remove eslint-plugin-tailwindcss
- These were commented out in eslint.config.ts by the backported PR

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 30, 2025
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 10/31/2025, 04:16:11 AM UTC

📈 Summary

  • Total Tests: 211
  • Passed: -108 ✅
  • Failed: 14 ❌
  • Flaky: 1 ⚠️
  • Skipped: 304 ⏭️

📊 Test Reports by Browser


🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Prettier formatting

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 30, 2025
@christian-byrne christian-byrne merged commit daa9aff into rh-test Oct 31, 2025
13 of 20 checks passed
@christian-byrne christian-byrne deleted the backport-6378-to-rh-test branch October 31, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants