Vue Node Header & Collapse #4387
Draft
+266
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benceruleanlu
changed the title
This reverts commit 233ecd7.
The 'title-edit' emit was defined but never used. Removed the emit definition and its invocation in handleDoubleClick(). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
benceruleanlu
requested review from
Yorha4D,
KarryCharon,
shinshin86 and
a team
as code owners
|
@christian-byrne Fixed based on your review comments, but do note that there is currently no reactivity between litegraph and Vue. Are we going to have a pseudo fix for that soon, or should I update this PR to manually sync with litegraph so litegraph -> vue changes are synced properly? |
|
Did someone say litegraph? 👂 If you want a quick architectural sounding-board chat on how to make some interop work, I have one good eye and am down for discussion. |
That would be very helpful. We are looking to potentially add some new event emits on litegraph. How's Monday evening after v3 meeting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds node header title editing and collapse, synced properly with litegraph.
Also has some formatting changes.
┆Issue is synchronized with this Notion page by Unito