Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetLogSubrangeWithLimit message to query log ranges by window and maximum events #166

Merged
merged 8 commits into from
Feb 28, 2025

Conversation

HaloFour
Copy link
Collaborator

@HaloFour HaloFour commented Feb 16, 2025

Adds a new LogQuery message for querying the Sirius log for a subrange based on a range of sequences and a maximum limit of events to include in the response. This would allow catchup to specify a larger window of events that is capped by a maximum number of events so that the returned list would be more full in the case of gaps caused by compaction.

Copy link
Collaborator

@jryan128 jryan128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HaloFour HaloFour changed the title Add GetLogRangeLimit message to query log ranges by start and maximum events Add GetLogSubrangeWithLimit message to query log ranges by window and maximum events Feb 28, 2025
@HaloFour HaloFour merged commit b69ca49 into master Feb 28, 2025
24 checks passed
@HaloFour HaloFour deleted the jbs/log-range-limit branch February 28, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants