N°8856 - Async retries of WebRequest not working properly#31
Open
odain-cbd wants to merge 4 commits into
Open
Conversation
Contributor
Author
There was a problem hiding this comment.
Pull request overview
This PR targets the webhook asynchronous sending/retry mechanism, adjusting how web requests are sent (sync vs async) and how async task failures are reported, alongside a module version bump.
Changes:
- Adjust singleton instantiation patterns in
WebRequestServiceandWebRequestSender(switching toself/new self()), and addWebRequestSender::SetInstance()for injection. - Simplify
WebRequestSender::Send()control flow to early-return for each send mode decision. - Update
SendWebRequest::DoProcess()status handling, including throwing on error, and bump module version to1.4.7.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/Service/WebRequestService.php |
Changes singleton instantiation to use self/new self() (impacts extension behavior). |
src/Service/WebRequestSender.php |
Changes singleton instantiation to use self/new self(), adds SetInstance(), and simplifies send-mode branching. |
SendWebRequest.php |
Adjusts async task processing result handling; throws an exception on send error and improves default status handling. |
module.combodo-webhook-integration.php |
Bumps module version from 1.4.6 to 1.4.7. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
15
to
22
| final public static function GetInstance(): WebRequestService | ||
| { | ||
| if (!isset(static::$oInstance)) { | ||
| static::$oInstance = new static(); | ||
| if (!isset(self::$oInstance)) { | ||
| self::$oInstance = new self(); | ||
| } | ||
|
|
||
| return static::$oInstance; | ||
| return self::$oInstance; | ||
| } |
Comment on lines
72
to
84
| public static function GetInstance() | ||
| { | ||
| if(static::$oInstance === null) | ||
| if(self::$oInstance === null) | ||
| { | ||
| static::$oInstance = new static(); | ||
| self::$oInstance = new self(); | ||
| } | ||
|
|
||
| return static::$oInstance; | ||
| return self::$oInstance; | ||
| } | ||
|
|
||
| public static function SetInstance(?WebRequestSender $oInstance) : void { | ||
| self::$oInstance = $oInstance; | ||
| } |
Contributor
Author
Contributor
Author
Member
|
Greptile only works on the iTop repo for now as it needs to be activated manually by the provider on open source repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix webhook async mecanism