Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testSuccessfulRetry and code to make it pass. #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielt1263
Copy link
Contributor

Update based on observation by @Kn1kt in issue #148

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #150 (b8ec4a3) into main (d7b896f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   95.47%   95.49%   +0.02%     
==========================================
  Files          72       72              
  Lines        4284     4287       +3     
==========================================
+ Hits         4090     4094       +4     
+ Misses        194      193       -1     
Impacted Files Coverage Δ
Sources/Operators/RetryWhen.swift 89.74% <100.00%> (-0.26%) ⬇️
Tests/RetryWhenTests.swift 94.66% <100.00%> (+1.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@robnadin
Copy link

What's the status of this and #151? Any reason they are not merged?

@WoodyHang
Copy link

Again, why not merge, I need to use this operator now @danielt1263

@danielt1263
Copy link
Contributor Author

Again, why not merge, I need to use this operator now @danielt1263

I don't think I have control over when this gets merged. Maybe @freak4pc could chime in here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants