Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TensorWaves amplitude analysis tutorial #487

Closed
11 tasks done
Tracked by #14
Zeyna777 opened this issue Apr 19, 2023 · 0 comments · Fixed by #489
Closed
11 tasks done
Tracked by #14

Improve TensorWaves amplitude analysis tutorial #487

Zeyna777 opened this issue Apr 19, 2023 · 0 comments · Fixed by #489
Assignees
Labels
📝 Docs Improvements or additions to documentation
Milestone

Comments

@Zeyna777
Copy link

Zeyna777 commented Apr 19, 2023

Some feedback to the Amplitude analysis tutorial.

  • Explain: if allowed_intermediate_particles is not specified, all possible intermediate resonances are considered
    --> The tutorial refers to QRules for further info and allowed_intermediate_particles is explained there

  • Hide JAX warning "No GPU/TPU found"

  • Syntax of coefficients changes when formalism is changed, e.g.:

    'C_{J/\psi(1S) \xrightarrow[S=2]{L=1} N(1520)^{+} \overline{p}; N(1520)^{+} \xrightarrow[S=1/2]{L=2} \eta p}': (1+0j) (CanHeli)
    'C_{J/\psi(1S) \to \overline{N}(1520)^{-}{+3/2} p{+1/2}; \overline{N}(1520)^{-} \to \eta_{0} \overline{p}_{+1/2}}': (1) (Heli)

    ->use intensity.parameters, so that you can just copy&paste if formalism or reaction is changed.

  • Hide JAX warning "No GPU found"

  • Remove max_complexity argument

  • Rename intensity to intensity_func

  • Show expressions for amplitude model

  • Merge (re)definition of reaction_info into reaction

  • Switch to MyST cross-references where possible

  • Plot resonance contributions, not spin projection contributions #490

  • Explain that sum of final state momenta has to be the rest frame of the decaying particle

Note: eventually, it would be better to address this through ComPWA/.github#14.

@redeboer redeboer changed the title Improve amplitude analysis tutorial Improve TensorWaves amplitude analysis tutorial Apr 19, 2023
@redeboer redeboer added the 📝 Docs Improvements or additions to documentation label Apr 19, 2023
@redeboer redeboer transferred this issue from another repository May 26, 2023
@redeboer redeboer added this to the 0.4.11 milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants