Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: work out exercises Lecture 2 #26

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

shenvitor
Copy link
Member

@shenvitor shenvitor commented Nov 10, 2023

Closes https://github.com/ComPWA/RUB-EP1-AG/issues/78
Temporary preview can be found here.

shenvitor and others added 29 commits October 19, 2023 16:16
Hiding back some code cells
Unfortuntaly not possible to suppress warnings about sphinx-exercise labels specifically
@shenvitor shenvitor self-assigned this Nov 10, 2023
@redeboer redeboer added the 📝 Docs Improvements or additions to documentation label Nov 10, 2023
@shenvitor shenvitor marked this pull request as ready for review November 10, 2023 11:04
@redeboer redeboer marked this pull request as draft November 10, 2023 12:28
@redeboer redeboer mentioned this pull request Nov 10, 2023
@redeboer
Copy link
Member

Keeping this as draft while working on https://github.com/ComPWA/RUB-EP1-AG/issues/90

Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of comments, still reviewing

docs/lecture02.ipynb Outdated Show resolved Hide resolved
docs/lecture02.ipynb Outdated Show resolved Hide resolved
docs/lecture02.ipynb Outdated Show resolved Hide resolved
docs/lecture02.ipynb Outdated Show resolved Hide resolved
docs/lecture02.ipynb Show resolved Hide resolved
docs/lecture02.ipynb Show resolved Hide resolved
docs/lecture02.ipynb Outdated Show resolved Hide resolved
docs/lecture02.ipynb Outdated Show resolved Hide resolved
docs/lecture02.ipynb Outdated Show resolved Hide resolved
docs/lecture02.ipynb Outdated Show resolved Hide resolved
docs/lecture02.ipynb Show resolved Hide resolved
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round of comments

Comment on lines +332 to +335
"% \\begin{pmatrix}\n",
"% \\frac{E_b^*}{p_b^*} & -\\frac{E_b^*}{m_b} \\\\\n",
"% -\\frac{E_b^*}{m_b} & \\frac{E_b^*}{p_b^*}\n",
"% \\end{pmatrix}\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No commented out code please 😅

" p_{b,z}^L\n",
"\\end{pmatrix} =\n",
"\\begin{pmatrix}\n",
" \\frac{E_b^*}{p_b^*} & -\\frac{E_b^*}{m_b} \\\\\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify how you get $\gamma$

"\\end{pmatrix}\n",
"$$\n",
"\n",
"When assuming $p_{b,z}^L=0$, then $E_{b}^L = m_b$, and thus\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what we wanted to proof, right?

"source": [
":::{solution} boost-exercise\n",
":class: dropdown\n",
"\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify what we want to proof (i.e., what the question means). In my understanding, we want to proof $(E_b^L, p_{b,z}^L) = (m_b, 0)$.

docs/lecture02.ipynb Outdated Show resolved Hide resolved
"cell_type": "markdown",
"metadata": {},
"source": [
"The data are in the lab frame, Compute and plot the $cosθ_L$ distribution.\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should put this under an exercise directive and toggle the solution as a dropdown, to improve the flow of the text.

"source": [
"The data are in the lab frame, Compute and plot the $cosθ_L$ distribution.\n",
"\n",
"Boost to the CoM and Compute and plot the $cosθ^*$ distribution"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace all unicode characters in Markdown cells with latex (in the code cells, unicode in variable names are okayish)

docs/lecture02.ipynb Outdated Show resolved Hide resolved
"metadata": {},
"outputs": [],
"source": [
"# 4-vector for a+b->1+2\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a comment, describe in a markdown cell above what is happening here

"metadata": {},
"outputs": [],
"source": [
"# 4-vector conservation\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write comment in markdown cell

@redeboer
Copy link
Member

The commits from 794fd2d should be in #32 (i.e. Lecture 11 should not be in this PR)

@redeboer redeboer self-requested a review December 9, 2023 18:18
@redeboer redeboer assigned redeboer and unassigned shenvitor May 6, 2024
@shenvitor
Copy link
Member Author

shenvitor commented Jul 16, 2024

BTW in the exercise today of MTHS school , in question 2.1 (2-to-2 Kinematics), most of them are similar or included in this PR doc, :)
which means it is a very classic introductory question in this area.

@redeboer
Copy link
Member

It is indeed 😁 Feel free to add a link to the exercises in this document as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants