-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: update analysis results with LS-model #262
Conversation
@redeboer how do you run the preview? |
Actually you can now just push to a new branch on the gitlab mirror and download the artifacts from the pipeline. But to update the preview website, checkout your branch and push to the preview repo: # git remote add preview https://gitlab.cern.ch/polarimetry/Lc2pKpi-preview.git
git push preview HEAD:main --force |
The pipeline will fail, because the uncertainties notebook asserts that decay rates haven't changed. Hope the resonance polarimeter notebook is still cached though, because that one takes ages to run... Does make me think we may need to write some tests that compares whether the framework produces the same results as the ones published in the paper. That way, you can refactor without affecting the physics results (want to do that for e.g. ComPWA/ampform#318) and we will also more easily see when results need to be updated. Also better to write it as a test, not as a notebook cell, so that the pipeline notices this earlier. |
At any rate, observables do seem to be very consistent now 🎉 |
great news |
Pipeline is finished, but the LS-model was not yet included in the resonance polarimeters and the polarization fit. Running a new pipeline, but here are the results: Extrema of the polarization values seem not to be affected by the inclusion of the LS-model. |
Fantastic. |
Yes and we need to make sure to inform the reviewers about the new values. For instance this "0.01% difference" should also be reformulated (assertion is based on 13 decimals, but need to reword that in science talk). |
Also, LHCb-PAPER-2022-002 was correct right? Only bugs in the framework for producing the cross-check values? |
No, there are 2 problems:
this is to be reported. |
Preview looks good ✔️ |
Once #192 is fixed, the last skipped model can be included to the list of systematics