Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

fix: correctly dump Breit-Wigner #395

Merged
merged 4 commits into from
Nov 26, 2020
Merged

fix: correctly dump Breit-Wigner #395

merged 4 commits into from
Nov 26, 2020

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Nov 26, 2020

There was a bug when dumpin an AmplitudeModel containing a RelativisticBreitWigner to YAML or XML. This PR fixes it.

Note: better solution is through #383, but this is more of a hot-fix that is required for TensorWaves, see e.g.
https://github.com/ComPWA/tensorwaves/pull/179/checks?check_run_id=1454030793

@redeboer redeboer added 🔨 Maintenance Refactoring that doesn't affect the interface Bug Something isn't working labels Nov 26, 2020
@redeboer redeboer self-assigned this Nov 26, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #395 (b0d33a8) into master (8e9d6f0) will increase coverage by 0.02%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   90.44%   90.47%   +0.02%     
==========================================
  Files          26       26              
  Lines        3599     3610      +11     
  Branches      874      877       +3     
==========================================
+ Hits         3255     3266      +11     
- Misses        172      173       +1     
+ Partials      172      171       -1     
Flag Coverage Δ
unittests 90.47% <56.25%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expertsystem/io/_xml/_build.py 85.35% <ø> (ø)
src/expertsystem/io/_xml/_dump.py 87.85% <50.00%> (+0.23%) ⬆️
src/expertsystem/io/_yaml/_dump.py 85.34% <57.14%> (+1.23%) ⬆️

@redeboer redeboer merged commit 16b8e23 into ComPWA:master Nov 26, 2020
@redeboer redeboer deleted the breit-wigner branch November 26, 2020 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working 🔨 Maintenance Refactoring that doesn't affect the interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants