Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: fix is_integer() bug for QRules v0.10.4 #450

Merged
merged 35 commits into from
Jan 29, 2025
Merged

FIX: fix is_integer() bug for QRules v0.10.4 #450

merged 35 commits into from
Jan 29, 2025

Conversation

grayson-helmholz
Copy link
Contributor

@grayson-helmholz grayson-helmholz commented Jan 17, 2025 •
edited by redeboer
Loading

@grayson-helmholz grayson-helmholz added the 🐛 Bug Something isn't working label Jan 17, 2025
@grayson-helmholz grayson-helmholz self-assigned this Jan 17, 2025
This was referenced Jan 17, 2025
Closed
Closed
@grayson-helmholz
Copy link
Contributor Author

Apparantly, the _GH-flag in test_cache.py is set to false on Ubuntu/Python3.12 - That would mean that either "CI" is not set as an environment-variable or the Darwin-kernel is actually used.

@redeboer redeboer mentioned this pull request Jan 17, 2025
Closed
@redeboer redeboer self-requested a review January 17, 2025 17:32
@redeboer redeboer changed the title FIX: fix is_integer-not-implemented bug for Fraction in Python < 3.12 FIX: fix is_integer() bug for QRules v0.10.4 Jan 17, 2025
@redeboer redeboer added this to the 0.15.6 milestone Jan 17, 2025
@redeboer redeboer mentioned this pull request Jan 22, 2025
Closed
@redeboer redeboer added 🔨 Maintenance Maintenance and upkeep improvements 🖱️ DX Improvements to the Developer Experience labels Jan 22, 2025
This was referenced Jan 22, 2025
Closed
Closed
@redeboer redeboer marked this pull request as draft January 22, 2025 12:41
redeboer
redeboer approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌜

@redeboer redeboer marked this pull request as ready for review January 24, 2025 09:54
@redeboer redeboer marked this pull request as draft January 24, 2025 16:15
@redeboer redeboer marked this pull request as ready for review January 29, 2025 13:10
@redeboer redeboer merged commit f3b2047 into main Jan 29, 2025
30 checks passed
@redeboer redeboer deleted the hotfix_fraction_is_integer_bug branch January 29, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redeboer redeboer redeboer approved these changes

Assignees

@grayson-helmholz grayson-helmholz

Labels
🐛 Bug Something isn't working 🖱️ DX Improvements to the Developer Experience 🔨 Maintenance Maintenance and upkeep improvements
Projects
None yet
Milestone
0.15.6
Development

Successfully merging this pull request may close these issues.

Formulation of Helicity model in "Modify amplitude model" results in Error
3 participants
@grayson-helmholz @redeboer @web-flow