Complete refactor on push menu plugin#5954
Open
dfsmania wants to merge 1 commit intoColorlibHQ:masterfrom
Open
Complete refactor on push menu plugin#5954dfsmania wants to merge 1 commit intoColorlibHQ:masterfrom
dfsmania wants to merge 1 commit intoColorlibHQ:masterfrom
Conversation
✅ Deploy Preview for adminlte-v4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Push Menu Plugin (AdminLTE v4)
This PR delivers a complete refactor of the Push Menu plugin, focusing on correctness, maintainability, and behavioral alignment with AdminLTE v3.
Summary of changes
1. Improved code documentation
2. Clear separation of responsibilities
3. Sidebar behavior aligned with AdminLTE v3
sidebar-openclass is now explicitly added when the sidebar is opened on mobile viewports.4. Sidebar state persistence is now opt-in
5. Single PushMenu instance
Why this refactor?
The Push Menu is a core UI component that combines:
This refactor aims to:
No visual regressions are expected, only more consistent and predictable behavior.