Update the upgrade file #1324
Update the upgrade file #1324
Conversation
WalkthroughA new section was added to the upgrading documentation to note a text change in an error message within the CiviCRM Main.php file. The message now uses "donate" instead of "contribute" when prompting for a minimum INR amount. No code logic or control flow was altered. Changes
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/upgrading.md (1)
100-107: Apply code-block fencing and close the sample line for accuracyThe before/after lines are rendered as plain text, so markdown swallows the dollar sign and braces, and the trailing comma inside
ts()looks like a syntax error.
Wrap the snippets in ```php fenced blocks and include the missing closing parenthesis / semicolon to avoid confusing copy-paste usage.-Old Text: -$errors["price_{$priceField->id}"] = ts('Thank you for your consideration, request you to contribute a minimum of INR %1', - -New Text: -$errors["price_{$priceField->id}"] = ts('Thank you for your consideration, request you to donate a minimum of INR %1', +Old Text +```php +$errors["price_{$priceField->id}"] = ts( + 'Thank you for your consideration, request you to contribute a minimum of INR %1', + [$minAmount] +); +``` + +New Text +```php +$errors["price_{$priceField->id}"] = ts( + 'Thank you for your consideration, request you to donate a minimum of INR %1', + [$minAmount] +); +```This improves readability and prevents accidental syntax omissions.
| **Note:** | ||
| The custom changes made to the receipt templates were implemented to meet specific project requirements and priorities. When updating CiviCRM, we need to revisit these templates and apply the necessary modifications accordingly. | ||
|
|
||
| ### 4. Modification On Main.php of CiviCRM | ||
| Changes on `wp-content/plugins/civicrm/civicrm/CRM/Contribute/Form/Contribution/Main.php` | ||
| Text Change; | ||
| Old Text: |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Section number duplicates existing heading “4.” — increment to maintain unique ordering
There is already a heading “4. Modification on event email template”. Re-using “4.” here breaks sequencing and can mislead readers skimming the doc.
Change this new heading to “5.” (or renumber all sections with an ordered list generator).
-### 4. Modification On Main.php of CiviCRM
+### 5. Modification on Main.php of CiviCRM📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| **Note:** | |
| The custom changes made to the receipt templates were implemented to meet specific project requirements and priorities. When updating CiviCRM, we need to revisit these templates and apply the necessary modifications accordingly. | |
| ### 4. Modification On Main.php of CiviCRM | |
| Changes on `wp-content/plugins/civicrm/civicrm/CRM/Contribute/Form/Contribution/Main.php` | |
| Text Change; | |
| Old Text: | |
| **Note:** | |
| The custom changes made to the receipt templates were implemented to meet specific project requirements and priorities. When updating CiviCRM, we need to revisit these templates and apply the necessary modifications accordingly. | |
| ### 5. Modification on Main.php of CiviCRM | |
| Changes on `wp-content/plugins/civicrm/civicrm/CRM/Contribute/Form/Contribution/Main.php` | |
| Text Change; | |
| Old Text: |
🤖 Prompt for AI Agents
In docs/upgrading.md around lines 97 to 103, the heading "4. Modification On
Main.php of CiviCRM" duplicates an existing section number "4." which breaks the
sequence. Change this heading number from "4." to "5." to maintain unique and
correct ordering of sections in the document.
Update the upgrade file
Summary by CodeRabbit