use weak_from_this() to detect if session ended before clipboard resp… #14433
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onse
A) A clipboard copy from a document on another coolwsd server
B) A paste of that clipboard to a document on this coolwsd server
C) This coolwsd attempts to contact the other coolwsd server
D) That attempt timeouts, for whatever reason, (routing, test vs production networks?)
E) Meanwhile the document on this coolwsd server was closed by the user, ending the session
F) The timeout arrives and that failure notice is delivered to the deleted session and we crash
can be reproduced manually by bodging:
- http::Session::create(url);
+ http::Session::create("http://10.255.255.1");
and the above steps
Signed-off-by: Caolán McNamara <[email protected]>
Change-Id: I0afc5cbc04f30ac2e3428b7a872533aa19b9999f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onse
A) A clipboard copy from a document on another coolwsd server B) A paste of that clipboard to a document on this coolwsd server C) This coolwsd attempts to contact the other coolwsd server D) That attempt timeouts, for whatever reason, (routing, test vs production networks?) E) Meanwhile the document on this coolwsd server was closed by the user, ending the session F) The timeout arrives and that failure notice is delivered to the deleted session and we crash
can be reproduced manually by bodging:
Change-Id: I0afc5cbc04f30ac2e3428b7a872533aa19b9999f
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay