Merged
Conversation
Contributor
Author
caolanm
force-pushed
the
private/caolan/more_calc_a11y
branch
5 times, most recently
from
c57d568 to
ca1d75a
Compare
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Id3ffeb934cbaf53fcf7bbb0aabeb37719544d428
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I754dad42500594fd6aff86de157809824f308ba7
There isn't a decoration close button. Perhaps we should just
send {esc}, but what we have works, so add something to pick
what button to close warning dialogs with.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I206e7611019b472bf4eb0ce0f2e8f5ed885a5616
caolanm
force-pushed
the
private/caolan/more_calc_a11y
branch
from
ca1d75a to
843c991
Compare
Contributor
Author
|
This add pivot table a11y etc tests to calc |
vmiklos
approved these changes
Feb 12, 2026
Contributor
vmiklos
left a comment
vmiklos
left a comment
There was a problem hiding this comment.
I see nothing problematic here.
| .parents('.jsdialog-window') | ||
| .invoke('attr', 'id') | ||
| .then(dialogId => { | ||
| cy.cGet(`#${CSS.escape(dialogId)} ` + buttonSelector) |
Contributor
There was a problem hiding this comment.
Ah, this CSS.escape() was new to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay