wsd/WopiStorage: prevent saving empty string as LastModifiedTime #14401
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the LastModifiedTime field is missing from the put_file upload, we would set the lastModifiedTiem to an invalid "". And output a warning if LastModifiedTime is not set as expected. Signed-off-by: Méven Car <[email protected]> Change-Id: Ib2d789f1bedd1621744f989065924e78169c0fd9
meven
commented
Feb 10, 2026
| LOG_TRC(wopiLog << " returns LastModifiedTime [" << lastModifiedTime << "]."); | ||
| setLastModifiedTime(lastModifiedTime); | ||
| if (lastModifiedTime.empty()) { | ||
| LOG_WRN(wopiLog << " Missing LastModifiedTime from PutFile answer."); |
Contributor
Author
There was a problem hiding this comment.
It could even be considered error/critical.
Contributor
Author
There was a problem hiding this comment.
We could even add a link to the documentation https://sdk.collaboraonline.com/docs/advanced_integration.html#detecting-external-document-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the LastModifiedTime field is missing from the put_file upload, we would set the lastModifiedTiem to an invalid "".
And output a warning if LastModifiedTime is not set as expected.
Change-Id: Ib2d789f1bedd1621744f989065924e78169c0fd9
Summary
So that the log can help us detect wopi issues.
The warning might be excessive, LastModifiedTime could be considered optional.
But this causes timestamp comparison failure creating conflicts.
To help upholding https://sdk.collaboraonline.com/docs/advanced_integration.html#detecting-external-document-change
Like in https://gitlab.com/pleio/platform/-/merge_requests/769/diffs
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay