Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edison: adding abbreviation extractor #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Edison: adding abbreviation extractor #335

wants to merge 1 commit into from

Conversation

danyaljj
Copy link
Member

@danyaljj danyaljj commented Jan 7, 2017 •
edited
Loading

Closes #334

@danyaljj danyaljj added the Edison label Jan 7, 2017
@danyaljj danyaljj changed the title adding abbreviation extractor Edison: adding abbreviation extractor Jan 7, 2017
mssammon
mssammon requested changes Jan 10, 2017
View reviewed changes
edison/src/test/java/edu/illinois/cs/cogcomp/edison/features/TestAbbreviationExtractor.java
} catch (AnnotatorException e) {
e.printStackTrace();
}
assert ta.getAvailableViews().contains(abbreviationFeatureExtractor.getViewName());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally, add at least one test for an expected abbreviation in the text, in a way that shows how a user would retrieve the relevant information from the TextAnnotation.

edison/src/test/java/edu/illinois/cs/cogcomp/edison/features/TestAbbreviationExtractor.java
assert ta.getAvailableViews().contains(abbreviationFeatureExtractor.getViewName());
assert ta.getView(abbreviationFeatureExtractor.getViewName()).getConstituents().size() >= 1;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the heavy use of parentheses in the abbreviation identifier, add a test case with multiple parens -- including unbalanced parentheses -- to demonstrate that it is robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssammon mssammon mssammon requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Edison
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyaljj @mssammon