Forcefully shutdown RPC to prevent hangs #6412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Category: Core - RPC/ZMQ
Kowlin
added
the
Type: Bug
yamikaitou
reviewed
Jul 19, 2024
There was a problem hiding this comment.
Tested and it works as expected (shutdown process continues after the 120 second timeout)
Jul 19 00:02:56 redbot python[737041]: [2024-07-19 00:02:56] [INFO] red.Audio.WS.LLNode: Shutdown Lavalink WS.
Jul 19 00:02:56 redbot python[737041]: [2024-07-19 00:02:56] [INFO] red.AAA3A-cogs.Dashboard: Unloading cog...
Jul 19 00:04:57 redbot python[737041]: [2024-07-19 00:04:57] [INFO] red.main: Shutting down with exit code: 26 (RESTART)
Jul 19 00:04:57 redbot python[737041]: [2024-07-19 00:04:57] [INFO] red.main: Please wait, cleaning up a bit more
Jul 19 00:05:00 redbot systemd[1]: itazura.service: Main process exited, code=exited, status=26/n/a
|
It works for me too! I was going to raise the subject again in #advanced-coding, fearing a problem in the way my Dashboard uses to create the websocket, but I've found this PR. ;P Thanks @Kowlin! 😃 |
|
seems to work for me also |
Jackenmen
approved these changes
Aug 4, 2024
There was a problem hiding this comment.
We should probably look into graceful shutdown at some point, see #4134 (review)
For now, let's just go with this, thanks!
red-githubbot
bot
added
the
Changelog Entry: Pending
BenCos17
added a commit
to JARVIS-discordbot/Red-DiscordBot-jarvis
that referenced
this pull request
Aug 4, 2024
* Set ProcessType in macOS auto-restart service to 'interactive' (Cog-Creators#6416) * Forcefully shutdown RPC to prevent hangs (Cog-Creators#6412) * Bump YT source plugin version to 1.5.1 and add custom plugin config (Cog-Creators#6415) --------- Co-authored-by: Jakub Kuczys <[email protected]> Co-authored-by: Kowlin <[email protected]>
Jackenmen
added
Changelog Entry: Added
BenCos17
added a commit
to JARVIS-discordbot/Red-DiscordBot-jarvis
that referenced
this pull request
Aug 4, 2024
* Set ProcessType in macOS auto-restart service to 'interactive' (Cog-Creators#6416) * Forcefully shutdown RPC to prevent hangs (Cog-Creators#6412) * Bump YT source plugin version to 1.5.1 and add custom plugin config (Cog-Creators#6415) * Fix unmuting when a mod isn't a mod anymore. (Cog-Creators#6411) Co-authored-by: TrustyJAID <[email protected]> * Bump dependencies (Cog-Creators#6417) * Red 3.5.11 - Changelog (Cog-Creators#6418) * Automated Crowdin downstream (Cog-Creators#6420) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Version bump to 3.5.11 (Cog-Creators#6419) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jakub Kuczys <[email protected]> * Version bump to 3.5.12.dev1 (Cog-Creators#6421) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Jakub Kuczys <[email protected]> Co-authored-by: Kowlin <[email protected]> Co-authored-by: TrustyJAID <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Dav-Git
pushed a commit
to Dav-Git/Red-DiscordBot
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Fixed #6391.
Have the changes in this PR been tested?
No, but it should just work. If not, its aiohttp's fault.