Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unmuting when a mod isn't a mod anymore. #6411

Merged
merged 3 commits into from
Aug 4, 2024

Conversation

Kowlin
Copy link
Member

@Kowlin Kowlin commented Jul 18, 2024

Description of the changes

Fixes #6376.

Have the changes in this PR been tested?

Yes

@Kowlin Kowlin requested a review from TrustyJAID as a code owner July 18, 2024 20:51
@github-actions github-actions bot added the Category: Cogs - Mutes This is related to the Mutes cog. label Jul 18, 2024
@Kowlin Kowlin added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 18, 2024
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

channel_unmute_user() call in _auto_channel_unmute_user() method appears to need a similar change.

@Jackenmen Jackenmen modified the milestones: 3.5.11, 3.5.12 Aug 4, 2024
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Jackenmen Jackenmen merged commit 2d47d75 into Cog-Creators:V3/develop Aug 4, 2024
17 checks passed
@Jackenmen Jackenmen deleted the pr/fix/automated-unmuting branch August 4, 2024 21:01
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Aug 4, 2024
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Aug 4, 2024
BenCos17 added a commit to JARVIS-discordbot/Red-DiscordBot-jarvis that referenced this pull request Aug 4, 2024
* Set ProcessType in macOS auto-restart service to 'interactive' (Cog-Creators#6416)

* Forcefully shutdown RPC to prevent hangs (Cog-Creators#6412)

* Bump YT source plugin version to 1.5.1 and add custom plugin config (Cog-Creators#6415)

* Fix unmuting when a mod isn't a mod anymore. (Cog-Creators#6411)

Co-authored-by: TrustyJAID <[email protected]>

* Bump dependencies (Cog-Creators#6417)

* Red 3.5.11 - Changelog (Cog-Creators#6418)

* Automated Crowdin downstream (Cog-Creators#6420)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Version bump to 3.5.11 (Cog-Creators#6419)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jakub Kuczys <[email protected]>

* Version bump to 3.5.12.dev1 (Cog-Creators#6421)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Jakub Kuczys <[email protected]>
Co-authored-by: Kowlin <[email protected]>
Co-authored-by: TrustyJAID <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Mutes This is related to the Mutes cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutes not unmuting when moderator is not a moderator
3 participants