Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RedTree] add UserFeedbackCheckFailure for app_commands #6397

Merged
merged 8 commits into from
Jul 12, 2024
Merged

[RedTree] add UserFeedbackCheckFailure for app_commands #6397

merged 8 commits into from
Jul 12, 2024

Conversation

japandotorg
Copy link
Contributor

Description of the changes

Add a UserFeedbackCheclkFailure exception class with configurable message which is handled within RedTree.on_error

Have the changes in this PR been tested?

No

@github-actions github-actions bot added Category: Core - API - Other This is related to core APIs that don't have a dedicated label. Category: Core - API - App Commands Package This is related to the `redbot.core.app_commands` package. labels Jul 8, 2024
Flame442
Flame442 requested changes Jul 10, 2024
View reviewed changes
redbot/core/tree.py Outdated Show resolved Hide resolved
redbot/core/app_commands/errors.py Outdated Show resolved Hide resolved
@Flame442 Flame442 self-assigned this Jul 10, 2024
@Flame442 Flame442 added the Type: Feature New feature or request. label Jul 10, 2024
@Flame442 Flame442 added this to the 3.5.11 milestone Jul 10, 2024
@japandotorg
Copy link
Contributor Author

that should be it, requested changes have been made.

@github-actions github-actions bot added Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. labels Jul 10, 2024
@github-actions github-actions bot added the Category: Meta This is related to the repository maintenance. label Jul 10, 2024
Flame442
Flame442 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Flame442 Flame442 merged commit bf8c0d0 into Cog-Creators:V3/develop Jul 12, 2024
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jul 12, 2024
@Jackenmen Jackenmen modified the milestones: 3.5.12, 3.5.11 Aug 4, 2024
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackenmen Jackenmen Jackenmen left review comments

@Flame442 Flame442 Flame442 approved these changes

Assignees

@Flame442 Flame442

Labels
Category: Core - API - App Commands Package This is related to the `redbot.core.app_commands` package. Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. Category: Core - API - Other This is related to core APIs that don't have a dedicated label. Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Category: Meta This is related to the repository maintenance. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Feature New feature or request.
Projects
None yet
Milestone
3.5.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@japandotorg @Jackenmen @Flame442