Fix [p]diagnoseissues
edge case for commands without a cog
#6237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
ctx.cog
can beNone
for commands without a cog which I do account for in the logic but apparently I forgot to also account for it when making the label. I simply rephrased it such that it doesn't include the cog name.The issue can be reproduced by adding a global deny rule (through Permissions cog) for the help command for a user (make sure NOT to check on bot owner who can run commands regardless of permissions cog):
With that setup, running
diagnoseissues USER help
without this PR should cause this uncatched exception:With this PR, however, the issue is properly reported and there are no uncatched exceptions.
Have the changes in this PR been tested?
Yes