Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #6185

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Bump dependencies #6185

merged 2 commits into from
Jul 23, 2023

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Jun 12, 2023

Description of the changes

Meaningful changes:

  • orjson wheels are built for base x86-64 instruction set again
    • Should we back out on dropping support for it considering that this was the only dependency that was causing problems for us?
  • the search in sphinx-rtd-theme now works again

Have the changes in this PR been tested?

Yes

macOS x86_64: https://github.com/Jackenmen/Red-Install-Tests/actions/runs/5336827530
Everything else: https://cirrus-ci.com/build/5771016132100096

@Jackenmen Jackenmen added the Type: Dependency Update Adding/updating/removing some of Red’s dependencies. label Jun 12, 2023
@Jackenmen Jackenmen added this to the 3.5.3 milestone Jun 12, 2023
@github-actions github-actions bot added the Category: Meta This is related to the repository maintenance. label Jun 12, 2023
@Drapersniper
Copy link
Contributor

Should we back out on dropping support for it considering that this was the only dependency that was causing problems for us?

Is it just a temporary thing or have they committed to support it long term? if it's just a temporary thing it probably makes sense to drop it in 3.6.

If it's a long-term support decision then keeping it is beneficial to users.

@Flame442 Flame442 self-assigned this Jun 13, 2023
Flame442
Flame442 previously approved these changes Jun 13, 2023
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feelings on (officially) supporting/not the old instruction set, it affected ~10 people total who spoke up so it's not a wide problem...

@Kowlin
Copy link
Member

Kowlin commented Jun 13, 2023

No hard feelings either way from me regarding Orjson's changes.

@Jackenmen Jackenmen modified the milestones: 3.5.4, 3.5.3 Jun 19, 2023
@Kowlin
Copy link
Member

Kowlin commented Jun 27, 2023

Do we want to include a bump to Discord.py v2.3.1?

@Jackenmen
Copy link
Member Author

Yes, I'll update this PR with more up-to-date version bumps later since I still am not sure when the release will actually be happening.

@Jackenmen
Copy link
Member Author

I bumped the deps again since I'm considering doing a release within the following days.

@Jackenmen Jackenmen merged commit 8e1b906 into Cog-Creators:V3/develop Jul 23, 2023
16 checks passed
@Jackenmen Jackenmen deleted the bump_deps branch July 23, 2023 21:14
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jul 23, 2023
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Jul 24, 2023
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Meta This is related to the repository maintenance. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Dependency Update Adding/updating/removing some of Red’s dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants