Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _ValueCtxManager.__await__ typehint #6163

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix _ValueCtxManager.__await__ typehint #6163

merged 1 commit into from
Jul 19, 2023

Conversation

Zephyrkul
Copy link
Contributor

Description of the changes

_ValueCtxManager.__await__ had an incorrect typehint which made pyright believe the object wasn't awaitable.

Have the changes in this PR been tested?

Yes

@github-actions github-actions bot added the Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. label May 15, 2023
Jackenmen
Jackenmen approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Jackenmen Jackenmen added this to the 3.5.3 milestone Jul 19, 2023
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 19, 2023
@Jackenmen Jackenmen merged commit 48cfde7 into Cog-Creators:V3/develop Jul 19, 2023
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jul 19, 2023
@Zephyrkul Zephyrkul deleted the await-typehints branch July 21, 2023 16:24
@Jackenmen Jackenmen added Changelog Entry: Skipped Changelog entry for this PR is unnecessary. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Jul 24, 2023
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
@Zephyrkul @Dav-Git
Fix _ValueCtxManager.__await__ typehint (Cog-Creators#6163)
d045163 
Co-authored-by: zephyrkul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackenmen Jackenmen Jackenmen approved these changes

Assignees
No one assigned
Labels
Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Changelog Entry: Skipped Changelog entry for this PR is unnecessary. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Zephyrkul @Jackenmen