-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement [p]trivia info
and add DESCRIPTION
to trivia schema
#5897
Implement [p]trivia info
and add DESCRIPTION
to trivia schema
#5897
Conversation
The example given for the description of logo trivia in the guide kind of makes me want to show the description in the startup message (as sort of an introduction) but that wouldn't really work when multiple trivia lists are selected, oh well... |
Co-authored-by: Jakub Kuczys <[email protected]>
Co-authored-by: Jakub Kuczys <[email protected]>
Co-authored-by: Jakub Kuczys <[email protected]>
Co-authored-by: Jakub Kuczys <[email protected]>
…ation string Co-authored-by: Jakub Kuczys <[email protected]>
…tion string Co-authored-by: Jakub Kuczys <[email protected]>
…kreusada/Red-DiscordBot into trivia-info-and-description-key
Co-authored-by: Jakub Kuczys <[email protected]>
…kreusada/Red-DiscordBot into trivia-info-and-description-key
Feel free to go ahead with it then. I don't really have any suggestions on how this should look, do whatever you think will look good I guess.
Probably not worth it, let's just assume nobody cares about seeing a compact version of the category list. |
#5565 has been merged, this requires some changes now |
Hi, just reminding you that this PR is waiting on the addition of descriptions to the |
I've managed a quick implementation through using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've managed a quick implementation through using the get_trivia_list() method. However, this isn't ideal at all as it requires opening each trivia list file through the iteration, making the command slow to produce output
I see, I didn't realize this will become a concern here. While I do think we should pursue this, I don't want to make this PR's approval contingent on this change. I went ahead and added missing descriptions for recently added trivias, moved the length check to schema, and made some other small chore changes. Thanks for contributing!
…g-Creators#5897) Co-authored-by: Jakub Kuczys <[email protected]>
Description of the changes
Adds a new command,
[p]trivia info <category>
, as well as a newDESCRIPTION
key to the trivia list schema.DESCRIPTION
is an optional key, just likeAUTHOR
.DESCRIPTION
will appear only in[p]trivia info
as of now.The idea came from @japandotorg in the Red server. If this PR is accepted and merged, #5565 will need to be updated to include this new key.
Fixes #3978
Don't be alarmed by the number of files changed, this PR is also adding DESCRIPTION keys to existing core lists and there are only a few files where code has been changed
Have the changes in this PR been tested?
Yes