Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Wrap #40

Merged
merged 5 commits into from
Nov 24, 2022
Merged

Text Wrap #40

merged 5 commits into from
Nov 24, 2022

Conversation

shiffman
Copy link
Member

Working on #39 in this branch.

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for ct-oregon-trail ready!

Name Link
🔨 Latest commit be786c9
🔍 Latest deploy log https://app.netlify.com/sites/ct-oregon-trail/deploys/637faf1d4ae52800085dd82c
😎 Deploy Preview https://deploy-preview-40--ct-oregon-trail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shiffman shiffman changed the title [WIP] Text Wrap Text Wrap Nov 24, 2022
@shiffman
Copy link
Member Author

@Rodak123 I added text wrap though it's not really tested beyond the one page. I noticed a couple things with the font.

  1. Missing "-" character for "water-filled"
  2. The line-height is very compressed, is this a font setting or something to add in the code?

Screen Shot 2022-11-24 at 10 33 15 AM Screen Shot 2022-11-24 at 10 33 08 AM

@shiffman
Copy link
Member Author

This is the non-mono font, the letter spacing is better but the SPACE character itself is off I believe?

Screen Shot 2022-11-24 at 10 37 30 AM

@Rodak123
Copy link
Contributor

@shiffman I updated the font in #42

@shiffman
Copy link
Member Author

There is a lot more to be done here but going to merge this as the foundation is there.

@shiffman shiffman merged commit 215f617 into main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants