🔧 chore(release): sync dev/v1.6 into main for v1.6.0-rc.8 - #629
Merged
Conversation
Wholesale-tree sync: this commit's tree is dev/v1.6 at 3331000.
scttbnsn
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
July 28, 2026 17:12
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe PR updates Crowdin integration-branch checkout and release artifact promotion workflows, including changelog snapshots and prerelease-only signing. It refreshes GitHub Action and dependency pins, advances release metadata to Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/triggers/providers/Trigger.ts (1)
937-950: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse existing
getCategory()helper instead of callinggetTriggerCategoryForTypedirectly.Every other call site in this class (
getMustTriggerDecision,isAutomaticActionDispatchBlocked) goes throughthis.getCategory(). This new check bypasses it.♻️ Proposed fix
if ( !dispatchDecision.enabled && dispatchDecision.reason === 'excluded-from-allow-list' && - getTriggerCategoryForType(this.type) === 'action' + this.getCategory() === 'action' ) {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/triggers/providers/Trigger.ts` around lines 937 - 950, Update the new allow-list exemption check to use this.getCategory() instead of calling getTriggerCategoryForType(this.type) directly, matching the existing getMustTriggerDecision and isAutomaticActionDispatchBlocked call sites while preserving the action-category condition.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/api/portwing-ws.test.ts`:
- Line 1353: Remove the duplicate errorFrame declarations in the affected test
callback, retaining a single const errorFrame declaration and updating
subsequent assertions to reuse it so the callback compiles.
---
Nitpick comments:
In `@app/triggers/providers/Trigger.ts`:
- Around line 937-950: Update the new allow-list exemption check to use
this.getCategory() instead of calling getTriggerCategoryForType(this.type)
directly, matching the existing getMustTriggerDecision and
isAutomaticActionDispatchBlocked call sites while preserving the action-category
condition.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: e4f01de4-18e8-45bf-a540-5654747d9eda
⛔ Files ignored due to path filters (5)
CHANGELOG.mdis excluded by!CHANGELOG.mdapps/demo/package-lock.jsonis excluded by!**/package-lock.json,!**/package-lock.jsonapps/web/package-lock.jsonis excluded by!**/package-lock.json,!**/package-lock.jsone2e/package-lock.jsonis excluded by!**/package-lock.json,!**/package-lock.jsonpackage-lock.jsonis excluded by!**/package-lock.json,!**/package-lock.json
📒 Files selected for processing (99)
.github/tests/crowdin-workflow.test.ts.github/tests/harden-runner-workflow.test.ts.github/tests/release-cut-ga-promotion.test.ts.github/tests/release-cut-retry-workflow.test.ts.github/workflows/ci-verify.yml.github/workflows/e2e-playwright.yml.github/workflows/i18n-crowdin.yml.github/workflows/quality-mutation-monthly.yml.github/workflows/release-cut.yml.github/workflows/security-grype.yml.github/workflows/security-scorecard.yml.gitleaksignoreREADME.mdapp/agent/AgentClient.test.tsapp/agent/AgentClient.tsapp/agent/api/index.test.tsapp/api/agent.test.tsapp/api/container.test.tsapp/api/container.tsapp/api/container/crud.test.tsapp/api/container/handlers/list.test.tsapp/api/container/security.test.tsapp/api/container/update-policy.test.tsapp/api/container/update-policy.tsapp/api/group.test.tsapp/api/portwing-ws.test.tsapp/api/preferences.test.tsapp/api/preview-errors.test.tsapp/authentications/providers/basic/Basic.test.tsapp/authentications/providers/oidc/Oidc.test.tsapp/configuration/index.test.tsapp/debug/dump.test.tsapp/event/index.test.tsapp/model/container.test.tsapp/registries/providers/ecr/Ecr.test.tsapp/registries/providers/shared/basicAuthProviderErrorPaths.test.tsapp/registries/token-bucket.test.tsapp/registry/index.test.tsapp/security/backends/docker.test.tsapp/security/runtime.test.tsapp/security/sbom-storage.test.tsapp/security/scan.test.tsapp/store/container.test.tsapp/store/container.tsapp/store/notification.tsapp/tag/index.test.tsapp/triggers/providers/Trigger.test.tsapp/triggers/providers/Trigger.tsapp/triggers/providers/docker/Docker.configuration-container-ops.test.tsapp/triggers/providers/docker/self-update-finalize-entrypoint.test.tsapp/triggers/providers/dockercompose/Dockercompose.test.tsapp/triggers/providers/kafka/Kafka.test.tsapp/triggers/providers/mqtt/Hass.test.tsapp/triggers/providers/mqtt/Mqtt.test.tsapp/triggers/providers/mqtt/hass-commands.test.tsapp/triggers/providers/smtp/Smtp.test.tsapp/triggers/trigger-category.test.tsapp/watchers/providers/docker/Docker.containers.labels-version-finding.test.tsapp/watchers/providers/docker/Docker.containers.test.tsapp/watchers/providers/docker/Docker.test.tsapp/watchers/providers/docker/docker-image-details-orchestration.test.tsapps/demo/package.jsonapps/demo/public/mockServiceWorker.jsapps/demo/src/mocks/data/agents.tsapps/demo/src/mocks/data/audit.tsapps/demo/src/mocks/data/containers.tsapps/demo/src/mocks/data/server.tsapps/demo/src/mocks/handlers/app.tsapps/web/package.jsonapps/web/src/lib/site-config.tsapps/web/src/lib/site-content.tsbiome.jsoncontent/docs/current/api/agent.mdxcontent/docs/current/api/app.mdxcontent/docs/current/api/portwing.mdxcontent/docs/current/configuration/triggers/index.mdxcontent/docs/current/quickstart/index.mdxcontent/docs/current/updates/index.mdxe2e/package.jsone2e/tests/security/picomatch-lockfile.test.jse2e/tests/security/yaml-lockfile.test.jspackage.jsonscripts/changelog-links.test.mjsscripts/release-docs-identity.test.mjsscripts/release-identity.test.mjsui/tests/components/containers/ContainerLinkActions.spec.tsui/tests/components/containers/ContainersGroupedViews.button-states.spec.tsui/tests/components/containers/ContainersGroupedViews.spec.tsui/tests/composables/useUpdateStatus.spec.tsui/tests/layouts/AppLayout.spec.tsui/tests/preferences/migrate.spec.tsui/tests/preferences/sync.spec.tsui/tests/security/mockServiceWorker-origin-check.spec.tsui/tests/services/preview.spec.tsui/tests/views/ConfigView.spec.tsui/tests/views/ContainersView.spec.tsui/tests/views/containers/useContainerActions.spec.tsui/tests/views/dashboard/DashboardGrid.spec.tsui/tests/views/dashboard/useDashboardComputed.spec.ts
| const ws = sendHelloWithAgentName(badValue); | ||
| await new Promise((r) => setTimeout(r, 0)); | ||
|
|
||
| const errorFrame = JSON.parse(ws.sentMessages[0]) as { type: string; data: { code: string } }; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
Remove the duplicate errorFrame declarations.
The supplied final code declares const errorFrame three times in the same callback. Keep one declaration; otherwise the test will not compile.
Proposed fix
- const errorFrame = JSON.parse(ws.sentMessages[0]) as { type: string; data: { code: string } };
- const errorFrame = JSON.parse(ws.sentMessages[0]) as { type: string; data: { code: string } };
- const errorFrame = JSON.parse(ws.sentMessages[0]) as { type: string; data: { code: string } };
+ const errorFrame = JSON.parse(ws.sentMessages[0]) as { type: string; data: { code: string } };📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const errorFrame = JSON.parse(ws.sentMessages[0]) as { type: string; data: { code: string } }; | |
| const errorFrame = JSON.parse(ws.sentMessages[0]) as { type: string; data: { code: string } }; |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@app/api/portwing-ws.test.ts` at line 1353, Remove the duplicate errorFrame
declarations in the affected test callback, retaining a single const errorFrame
declaration and updating subsequent assertions to reuse it so the callback
compiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wholesale-tree sync: brings main tree-identical to
dev/v1.6at33310002ahead of the v1.6.0-rc.8 cut.Since rc.7's sync, dev/v1.6 landed:
Head is a server-side commit on top of
mainwhose tree equals dev's tip tree (raw dev tips conflict against main's squash history). After merge,git diff --quiet origin/main origin/dev/v1.6must pass — that's the release-cut drift-guard invariant.Cut follows:
release-cut.yml --ref main -f release_tag=v1.6.0-rc.8.Changelog
✨ Added
🔧 Changed
mainwithdev/v1.6forv1.6.0-rc.8.v1.6.0-rc.8.🐛 Fixed
🔒 Security
Concerns
mainanddev/v1.6have identical trees after merging.