Clamp negative cursor animation duration in AndroidViewContainer#2632
Open
AndreiGorelov wants to merge 2 commits intoCoderLine:developfrom
Open
Clamp negative cursor animation duration in AndroidViewContainer#2632AndreiGorelov wants to merge 2 commits intoCoderLine:developfrom
AndreiGorelov wants to merge 2 commits intoCoderLine:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2616
Proposed changes
In
AndroidViewContainer.transitionToX, clamp the animation duration with positive values before calling Animation.setDuration, so Android never throwsIllegalArgumentException: Animation duration cannot be negativewhen playback, autoscroll, and user scrolling interact (e.g. off-screen).This is a defensive platform fix.
Checklist
No new automated tests: the failure depends on Android animation APIs and a manual playback and scroll scenario. Verified manually with real devices.
Further details