This repository has been archived by the owner on Feb 13, 2019. It is now read-only.
Add query bus supporting more than one handler #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review this on the weekend! :) |
JavierCane
approved these changes
Jan 24, 2018
There was a problem hiding this comment.
Very good work @GMadorell!
I've just added a suggestion regarding the mutability of the QueryBus. Please, tell me what do you think about it 🙂
Thanks!!
| @@ -4,4 +4,6 @@ import java.util.UUID | |||
|
|
|||
| import org.joda.time.DateTime | |||
|
|
|||
| abstract class Query(val queryId: UUID, val askedAt: DateTime) extends Request(queryId, askedAt) | |||
| abstract class Query(val queryId: UUID, val askedAt: DateTime) extends Request(queryId, askedAt) { | |||
| type QueryResponse <: Response | |||
There was a problem hiding this comment.
I didn't have used the types as you've done in this PR yet. Thanks for sharing!
| ) | ||
| ) | ||
| val queryBus = new QueryBus[EitherThrowable]() | ||
| queryBus.subscribe(generateUserGreetQueryHandler) |
There was a problem hiding this comment.
Could you try to refactor this requiring to inject the subscribers while creating the QueryBus instance as we where doing?
This way we would be avoiding mutable state inside the QueryBus 🙂
If you don't have time in order to add this improvement, we could merge this PR and do that later 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2