Skip to content

fix: hide 'Show Chart' reminder message when in chart view mode #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HardeepAsrani wants to merge 1 commit into
base: development
Choose a base branch
from
+8 −2
Open

fix: hide 'Show Chart' reminder message when in chart view mode #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions classes/Visualizer/Render/Layout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@ public static function _renderTabBasic( $args ) {
data-t-editor="<?php _e( 'Show Chart', 'visualizer' ); ?>"
data-t-chart="<?php _e( 'Edit Data', 'visualizer' ); ?>"
>
<p class="viz-group-description viz-info-msg"><?php echo sprintf( __( 'Please make sure you click \'Show Chart\' before you save the chart.', 'visualizer' ) ); ?></p>
<p class="viz-group-description viz-info-msg" style="display:none"><?php echo sprintf( __( 'Please make sure you click \'Show Chart\' before you save the chart.', 'visualizer' ) ); ?></p>
</div>
<?php } else { ?>
<input type="button" id="editor-undo" class="button button-secondary" style="display: none" value="<?php _e( 'Undo Changes', 'visualizer' ); ?>">
Expand All @@ -799,7 +799,7 @@ public static function _renderTabBasic( $args ) {
data-t-editor="<?php _e( 'Show Chart', 'visualizer' ); ?>"
data-t-chart="<?php _e( 'View Editor', 'visualizer' ); ?>"
>
<p class="viz-group-description viz-info-msg"><?php echo sprintf( __( 'Please make sure you click \'Show Chart\' before you save the chart.', 'visualizer' ) ); ?></p>
<p class="viz-group-description viz-info-msg" style="display:none"><?php echo sprintf( __( 'Please make sure you click \'Show Chart\' before you save the chart.', 'visualizer' ) ); ?></p>
<?php } ?>
</form>
</div>
Expand Down
6 changes: 6 additions & 0 deletions js/simple-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
button.html( button.attr( 'data-t-chart' ) );
button.attr( 'data-current', 'chart' );
$('p.viz-editor-selection').show();
$('p.viz-info-msg').hide();
$('.viz-text-editor').hide();
$('.viz-simple-editor').hide();
$( '#canvas' ).css('z-index', '1').show();
Expand All @@ -40,6 +41,7 @@
button.html( button.attr( 'data-t-editor' ) );
button.attr( 'data-current', 'editor' );
$('p.viz-editor-selection').hide();
$('p.viz-info-msg').show();
$('.viz-text-editor').css('z-index', '9999').show();
$('.viz-simple-editor').css('z-index', '9999').show();
$( '#canvas' ).css('z-index', '-100').hide();
Expand All @@ -53,6 +55,7 @@
button.html( button.attr( 'data-t-chart' ) );
button.attr( 'data-current', 'chart' );
$('p.viz-editor-selection').show();
$('p.viz-info-msg').hide();
$('.viz-text-editor').hide();
$('.viz-simple-editor').hide();
$( '#canvas' ).css('z-index', '1').show();
Expand All @@ -74,6 +77,7 @@
button.html( button.attr( 'data-t-chart' ) );
button.attr( 'data-current', 'chart' );
$('p.viz-editor-selection').show();
$('p.viz-info-msg').hide();
$('.viz-table-editor').hide();
$('.viz-simple-editor').hide();
$( '#canvas' ).css('z-index', '1').show();
Expand All @@ -84,6 +88,7 @@
button.html( button.attr( 'data-t-editor' ) );
button.attr( 'data-current', 'editor' );
$('p.viz-editor-selection').hide();
$('p.viz-info-msg').show();
$( '.viz-table-editor' ).css("z-index", "9999").show();
$('.viz-simple-editor').css('z-index', '9999').show();
$('body').trigger('visualizer:db:editor:table:redraw', {});
Expand All @@ -98,6 +103,7 @@
button.html( button.attr( 'data-t-chart' ) );
button.attr( 'data-current', 'chart' );
$('p.viz-editor-selection').show();
$('p.viz-info-msg').hide();
$('.viz-table-editor').hide();
$('.viz-simple-editor').hide();
$( '#canvas' ).css('z-index', '1').show();
Expand Down
Loading