Skip to content

fix(DataList): Go back to first-of-type approach for padding#3294

Open
LinKCoding wants to merge 1 commit intomainfrom
kl-gmt-1544-datalist-padding-back-on-th-td
Open

fix(DataList): Go back to first-of-type approach for padding#3294
LinKCoding wants to merge 1 commit intomainfrom
kl-gmt-1544-datalist-padding-back-on-th-td

Conversation

@LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Mar 19, 2026

Overview

Applies padding to td and th of List, DataList, and DataTable through first-of-type CSS rules.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1544
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

To be compared against: #3277

  1. Go to DataList see that the spacing is all the same
  2. The Header row should still have the headers aligned with the checkbox, and check for the "Non-selectable rows" story to see that the Headers are bottom aligned
  3. Check that DataTable looks the same
  4. Check that List all looks the same
  5. ...
  6. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Mono Mono PR

@LinKCoding LinKCoding changed the title go back to first-of-type approach fix(DataList): Go back to first-of-type approach for padding Mar 19, 2026
@nx-cloud
Copy link

nx-cloud bot commented Mar 19, 2026

View your CI Pipeline Execution ↗ for commit 8ed981d


☁️ Nx Cloud last updated this comment at 2026-03-19 20:00:04 UTC

@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/gamut@68.1.5-alpha.62c8e0.0
@codecademy/gamut-kit@0.6.590-alpha.62c8e0.0

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.13%. Comparing base (c486633) to head (8ed981d).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3294      +/-   ##
==========================================
- Coverage   89.76%   89.13%   -0.64%     
==========================================
  Files         362      236     -126     
  Lines        5229     4344     -885     
  Branches     1701     1479     -222     
==========================================
- Hits         4694     3872     -822     
+ Misses        525      463      -62     
+ Partials       10        9       -1     
Flag Coverage Δ
main ?
pull-request 89.13% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

@LinKCoding LinKCoding marked this pull request as ready for review March 19, 2026 20:43
@LinKCoding LinKCoding requested a review from a team as a code owner March 19, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants