Skip to content

correct wording for GitHub link text#1887

Open
Liam310 wants to merge 2 commits into
mainfrom
github_navigation_wording_fix
Open

correct wording for GitHub link text#1887
Liam310 wants to merge 2 commits into
mainfrom
github_navigation_wording_fix

Conversation

@Liam310
Copy link
Copy Markdown
Contributor

@Liam310 Liam310 commented May 19, 2026

The text content of the link in question is actually "Browse files" rather than "Browse the repository at this point in the history" (the latter is in fact the text content of the tooltip that appears on hover). This PR amends that.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 19, 2026

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 14a5abd
🔍 Latest deploy log https://app.netlify.com/projects/cyf-common/deploys/6a0ef5043cd26f00082f1d2b
😎 Deploy Preview https://deploy-preview-1887--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 19, 2026

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 14a5abd
🔍 Latest deploy log https://app.netlify.com/projects/cyf-curriculum/deploys/6a0ef5043cd26f00082f1d27
😎 Deploy Preview https://deploy-preview-1887--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 16 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@illicitonion
Copy link
Copy Markdown
Member

Interesting - where do you see this text? When the screen is narrow I see:

Screenshot 2026-05-19 at 18 05 57

And when wide, I see no text except this tooltip:

Screenshot 2026-05-19 at 18 03 02

@Liam310
Copy link
Copy Markdown
Contributor Author

Liam310 commented May 21, 2026

Interesting - where do you see this text?

Ah interesting, it would seem we are looking in slightly different places! I think I interpreted the instructions differently (possibly incorrectly, now I read them again). What I did was actually click through the commit to get to this page, where you can see the link with text content "Browse files" and tooltip text "Browse the repository at this point in the history".

image

I still feel that the instructions could be clarified a little but I'm happy to revert my particular changes in favour of something slightly different.

@illicitonion
Copy link
Copy Markdown
Member

Makes sense! Give me a wave when you've made your tweaks!

@Liam310
Copy link
Copy Markdown
Contributor Author

Liam310 commented May 21, 2026

@illicitonion I've made the changes, feel free to review at your leisure 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋 Backlog

Development

Successfully merging this pull request may close these issues.

2 participants