Skip to content

Conversation

@Mahtem
Copy link

@Mahtem Mahtem commented Nov 15, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implementation and testing

Questions

Questions will be forwarded on time.

@Mahtem Mahtem added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module labels Nov 15, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation and testing

This does not quite describe what was changed in this PR branch (compared to CYF's main). Can you make the description more informative?


Are the changes made in "2-practice-tdd" related to this PR?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 21, 2025
@Mahtem Mahtem added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 21, 2025
@Mahtem
Copy link
Author

Mahtem commented Nov 21, 2025

Implementation and testing

This does not quite describe what was changed in this PR branch (compared to CYF's main). Can you make the description more informative?

Are the changes made in "2-practice-tdd" related to this PR?

Thank you @cjyuan, because I created a branch from the previous branch the commits of the previous branch "2-practice-tdd" were mixed with this PR. Now, I have created a new fixed branch (coursework/sprint-3-stretch-Fixed) with only related commits and files.

New and fixed PR:

Manchester | 25-ITP-Sep | Mahtem T. Mengstu | Sprint 3 | coursework/sprint-3-stretch-Fixed #884 #889

#889

@cjyuan
Copy link
Contributor

cjyuan commented Nov 21, 2025

You could practice using git command to rebase this branch onto main. Just ask ChatGPT how to rebase a branch created from the 2-practice-tdd branch onto 'main'.

@cjyuan cjyuan removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 21, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Nov 21, 2025

Since you have created a separate PR for Sprint-3/stretch, you may want to close this branch.

@Mahtem
Copy link
Author

Mahtem commented Nov 21, 2025

Since you have created a separate PR for Sprint-3/stretch, you may want to close this branch.

Okay, I will close it.

@Mahtem Mahtem closed this Nov 21, 2025
@Mahtem Mahtem deleted the coursework/sprint-3-stretch branch November 21, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants