Skip to content

London | 25-ITP-September | Carlos Abreu | Sprint 1 | Coursework #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-September | Carlos Abreu | Sprint 1 | Coursework #862

wants to merge 28 commits into from

Conversation

@carlosyabreu
Copy link

@carlosyabreu carlosyabreu commented Nov 8, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I'm asking to merge Coursework/Spring 1 into CYF main branch

Questions

@carlosyabreu
Increase by 1 the variable count
e1447e3
@carlosyabreu
Assignment operator equal
f184b29
@carlosyabreu
2-initials.js first letters of the variables
d88693e
@carlosyabreu
Directory and extension part of a file path
ad07e16
@carlosyabreu
Explanation of 4-random.js file
fc159be
@carlosyabreu
Using comment to explain the information contain in the file, useful …
92d1f33 
…only for developers
@carlosyabreu
Change keyword 'const' to 'let' to assign variable
204a98d
@carlosyabreu
Variable must be declared first before it can be used
b9538b2
@carlosyabreu
Extracting the last 4 digits and display it
5b6a38f
@carlosyabreu
Change variable naming starting with letter instead of numbers
57e97e9
@carlosyabreu
Change function replaceAll arguments adding commas to separate its pa…
7e75245 
…rameters and use Number function to convert into a Number
@carlosyabreu
commit 2-time-format.js and 3-to-pounds.js
a36e485
@carlosyabreu
Add alert and prompt function explanation
94b7128
@carlosyabreu
Console.log and Console and property
269ce23
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 8, 2025
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

2 similar comments
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@jennethydyrova jennethydyrova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 10, 2025
@jennethydyrova
Copy link
Contributor

jennethydyrova commented Nov 10, 2025 •
edited
Loading

Hi @carlosyabreu! Unfortunately, I have to reject your PR as I see that the majority of your answers and solutions are copy and pasted from some AI agent. Please avoid doing this in future as it's not a good use of neither your nor reviewer's time. Please provide your own solutions and I will take another look.

@jennethydyrova jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 10, 2025
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 11, 2025
@carlosyabreu
Copy link
Author

carlosyabreu commented Nov 11, 2025

Good afternoon Jenny

Thanks for reviewing my Sprint-1 PR.
I changed and updated the explanation (comments) related to the exercises using my own reasoning and words.
Actually I think it's more align of what you would expect from students.
Cheers!

jennethydyrova
jennethydyrova suggested changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@jennethydyrova jennethydyrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @carlosyabreu! PR looks fine but can you please remove commented out code and package-lock.json to keep the PR clean.

Sprint-1/1-key-exercises/2-initials.js Outdated
// This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution.

let initials = ``;
// let initials = ``;
Copy link
Contributor

@jennethydyrova jennethydyrova Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this commented code to keep the PR clean?

Copy link
Author

@carlosyabreu carlosyabreu Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evening Jenny

Thanks for your reply.
I've followed your suggestion removing the comment and update PR making the branch clean.
Before reading your suggestion I didn't know that bit of code shouldn't be there.
Again thank you.

Copy link
Contributor

@jennethydyrova jennethydyrova Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json is still there, can you please remove it as well?

Copy link
Author

@carlosyabreu carlosyabreu Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jenny

Sorry for delay.
I've deleted package-lock.json file.
I typed (git rm --cached package-lock.json) on terminal and committed and pushed to GitHub repo.
It's done.
And I created (.gitignore) file on local git repo and add (package-lock.json) on (.gitignore) so next next time I add, commit and push it doesn't be included onto GitHub upstream repo.
I think it's cleaned now.
Thank you

@jennethydyrova jennethydyrova removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 13, 2025
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jennethydyrova jennethydyrova jennethydyrova requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlosyabreu @jennethydyrova