West Midlands | 25-ITP-Sept | Ali Naru | Sprint 2 | Coursework/sprint-2

[MohammedNaru]

Sprint 2 Coursework

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Completed all coursework tasks on Sprint 2

Questions

No questions currently

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[cjyuan]

What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?

Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,

  console.log(123);              // Output 123
  console.log("123");            // Output 123
  
  // Treated differently in the program
  let sum1 = 123 + 100;         // Evaluate to 223 -- a number
  let sum 2 = "123" + 100;      // Evaluate to "123100" -- a string.

[MohammedNaru]

All updated now please can you review again.

[cjyuan]

Can you also answer my questions in this thread?

[MohammedNaru]

I expect the function to return a number, because BMI is a numeric value that can be used in further comparisons or calculations. In my earlier implementation, using .toFixed(1) caused the function to return a string instead of a number. Although the string appears the same in the console I understand it operates differently I have now updated the function so that it returns a number by converting the result back with parseFloat().

[cjyuan]

If you have updated the file, don't forget to push the changes to GitHub.

[cjyuan]

You missed one of my questions.

Also, the description of this PR written in the "Changelist" section does not quite tell me what was changed in this PR branch.