Skip to content

Conversation

@zilinskyte
Copy link

@zilinskyte zilinskyte commented Oct 20, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Errors predicted, detected and fixed
Function implementation
Code interpreted and following questions answered

Questions

@github-actions
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@zilinskyte zilinskyte changed the title West Midlands | West Midlands | 25-Sept-ITP | Georgina Rogers | Sprint-2 | Structing and Testing Data Oct 20, 2025
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

5 similar comments
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@zilinskyte zilinskyte changed the title West Midlands | 25-Sept-ITP | Georgina Rogers | Sprint-2 | Structing and Testing Data West Midlands | 25-Sept-ITP | Georgina Rogers | Sprint 2 | Structing and Testing Data Oct 20, 2025
@zilinskyte zilinskyte added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Oct 22, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added a bunch of unrelated files zilinskyte_Module-Structuring-and-Testing-Data_ ITP 2_files... to this branch. Can you remove them from this branch to keep it clean?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 25, 2025
@zilinskyte
Copy link
Author

You have added a bunch of unrelated files zilinskyte_Module-Structuring-and-Testing-Data_ ITP 2_files... to this branch. Can you remove them from this branch to keep it clean?

Hi CJ, I don't know what these files are or where they came from, how should i best go about finding and removing them?

@cjyuan
Copy link
Contributor

cjyuan commented Nov 3, 2025

The folder zilinskyte_Module-Structuring-and-Testing-Data_ ITP 2_files is in your repository (on branch coursework/sprint-2).
On your computer, if you switch to this branch, you should see the folder in your repo. You just need to delete it and then commit the change.

@zilinskyte zilinskyte added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 3, 2025
@zilinskyte
Copy link
Author

The folder zilinskyte_Module-Structuring-and-Testing-Data_ ITP 2_files is in your repository (on branch coursework/sprint-2). On your computer, if you switch to this branch, you should see the folder in your repo. You just need to delete it and then commit the change.

okay thank you I have done this now. is everything else okay for this sprint?

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 5, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Nov 5, 2025

All good now. Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants