West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | Coursework/sprint-1 #770
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint-3) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
MohammedNaru
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint-3) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
MohammedNaru
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
2 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
MohammedNaru
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
…onsole.log and enhance comments for clarity (2.js)
…ate comments for clarity
…mat calculation 2-time-format.js
MohammedNaru
added
the
Needs Review
Sprint-1/1-key-exercises/3-paths.js
Outdated
| const dir = ; | ||
| const ext = ; | ||
| const dir = filePath.slice(0, lastSlashIndex); | ||
| const ext = filePath.slice(lastSlashIndex); |
There was a problem hiding this comment.
Based on your understanding, what is the "ext" part of /Users/mitch/cyf/Module-JS1/week-1/interpret/file.txt?
There was a problem hiding this comment.
this refers to the file extension type
There was a problem hiding this comment.
Which part of the given path is the file extension? Does ext has the value you expect?
There was a problem hiding this comment.
extension refers to .txt, not file.txt. I fixed the code by slicing from the last . instead of the last /.
Sprint-1/1-key-exercises/4-random.js
Outdated
|
|
||
| // at the top we can see our minimum and maximum values which are fixed therefore Constants, | ||
| // we then have our variable num which is assigned a value using the Math object and its methods floor and random | ||
| // Math.random() generates a random decimal number between 0 (inclusive) and 1 (exclusive) |
There was a problem hiding this comment.
We can also use the concise and precise interval notation to describe a range of values.
[,]=> inclusion(,)=> exclusion
For example, we can say, "Math.random()returns a random number in the interval[0, 1)"
There was a problem hiding this comment.
thank you for the feedback I have now implemented and committed this
Sprint-1/2-mandatory-errors/4.js
Outdated
| const Twelve_HourClockTime = "20:53"; | ||
| const Twenty_Four_hourClockTime = "08:53"; |
There was a problem hiding this comment.
Names that begin with uppercase letters are conventionally used for types or classes (e.g., Math, Number, String).
For variables, the naming convention is to use camelCase.
There was a problem hiding this comment.
I understand would you need me to update this to match camelCase Convention for this exercise?
There was a problem hiding this comment.
Why not make the change to show you truly understand?
There was a problem hiding this comment.
I have now updated this to follow camelCase Convention
There was a problem hiding this comment.
This file is not related to Sprint-1 exercise. Can you revert the changes made to the file to keep this branch clean?
There was a problem hiding this comment.
I believe I have now reverted the file, I accidentally worked on that file before creating a new branch for sprint 2
There was a problem hiding this comment.
The file is still in this branch.
There was a problem hiding this comment.
I have now reverted it back to main so this file should no longer be there, please review.
cjyuan
added
Reviewed
MohammedNaru
added
Needs Review
cjyuan
added
Reviewed
…nhance comments for clarity.
MohammedNaru
added
Needs Review
|
Looks good! |
cjyuan
added
Complete
2 participants
Sprint 3 Coursework/sprint 1
Self checklist
Changelist
In 1-key exercise, I completed short JavaScript programs and tasks.
2- mandatory -errors exercises are complete. I ran the code in Node.js and wrote the reason for each error
3-mandatory -interpret exercises are complete
Questions
No questions.