Skip to content

Manchester |26-ITP-May| SamreenAmjad |Sprint 1 | Form-Controls#1336

Open
serveyano wants to merge 1 commit into
CodeYourFuture:mainfrom
serveyano:main
Open

Manchester |26-ITP-May| SamreenAmjad |Sprint 1 | Form-Controls#1336
serveyano wants to merge 1 commit into
CodeYourFuture:mainfrom
serveyano:main

Conversation

@serveyano
Copy link
Copy Markdown

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This PR creates a T-shirt order form using semantic HTML. It collects the user’s name, email, colour, and size.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 22, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 6709ec3
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a10200b9d94640008d182a6
😎 Deploy Preview https://deploy-preview-1336--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@serveyano serveyano added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels May 22, 2026
@Luro91 Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 23, 2026
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you get all lighthouse scores to 100?

Image

Comment thread Form-Controls/index.html
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>T-Shirt Order Form</title>

<style>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could you seperate the code for the styling from the html to make it easier to review (because of smaller files with seperate responsibilites)

Comment thread Form-Controls/index.html
name="name"
required
minlength="2"
pattern=".*\S.*"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on the input validation

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants