London | 26-ITP-May | Talia Kucuk | Sprint 1 | Form Controls#1260
Open
TaliaKucuk wants to merge 7 commits into
Open
London | 26-ITP-May | Talia Kucuk | Sprint 1 | Form Controls#1260TaliaKucuk wants to merge 7 commits into
TaliaKucuk wants to merge 7 commits into
Conversation
TaliaKucuk
commented
May 13, 2026
TaliaKucuk
commented
- I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
- My changes meet the requirements of the task
- I have tested my changes
- My changes follow the style guide
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
TaliaKucuk
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 14, 2026
There was a problem hiding this comment.
I like the styling of the form. It looks nice
Comment on lines
+18
to
+57
| <div> | ||
| <label for="name">Name:</label> | ||
| <input type="text" id="name" name="customers_name" required pattern=".*\S.*\S.*"> | ||
| </div> | ||
| <!-- 1. What is the customer's name? I must collect this data and | ||
| it contains at least two non-space characters. --> | ||
| <div><label for="mail">Email:</label> | ||
| <input type ="email" id="mail" name="customers_email" required></div> | ||
| <!-- 2. What is the customer's email? I must make sure the email is valid. | ||
| Email addresses follow a consistent pattern.--> | ||
| <div> | ||
| <label for="colour">Colour:</label> | ||
|
|
||
| <select id="colour" name="tshirt_colour" required> | ||
| <option value="" selected disabled>Choose a colour</option> | ||
| <option value="pink">Pink</option> | ||
| <option value="yellow">Yellow</option> | ||
| <option value="black">Black</option> | ||
| </select> | ||
| </div> | ||
| <!--3. What colour should this T-shirt be? I must provide 3 options. | ||
| How will I ensure they do not choose other colours?--> | ||
| <div> | ||
| <label for="size">Size:</label> | ||
|
|
||
| <select id="size" name="tshirt_size" required> | ||
| <option value="" selected disabled>Choose a size</option> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </div> | ||
| <!-- 4. What size does the customer want? I must provide the following 6 options: | ||
| XS, S, M, L, XL, XXL--> | ||
| <div class="button"> | ||
| <button type="submit">Submit</button> | ||
| </div> |
There was a problem hiding this comment.
I find the formatting of the code hard to read. How can you ensure consistent formatting in your code?
Author
There was a problem hiding this comment.
Hey, I installed the Prettier code formatting extension on VSCode and have now applied this. Hopefully the code is readable now?
There was a problem hiding this comment.
Thanks now its nicely formatted. As described in the style guidy: https://curriculum.codeyourfuture.io/guides/reviewing/style-guide/
Indentation helps us to read our code by visually marking how the code is going to run. Programmers rely on this extra information to quickly read and understand code.
You could configure VS code to use prettier to automatically format the code when you save the file. Then you have not to think about it
Luro91
added
Reviewed
TaliaKucuk
added
the
Needs Review
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.