Glasgow | 26-ITP-May | Lavanya Jayaprabu | Sprint 1 | Form Controls#1237
Glasgow | 26-ITP-May | Lavanya Jayaprabu | Sprint 1 | Form Controls#1237Lavanya-Projects wants to merge 9 commits into
Conversation
Added a customer name input field
Added customer email input field
Added radio button for the colour selection
Added a dropdown section for the size selection
Added submit button, validate the input fields
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| <label>Customer Name: </label> | ||
| <input required minlength="2" pattern=".*\S.*\S.*"> |
There was a problem hiding this comment.
Recommended to have id and name fields here (name field helps data be identified, id helps elements get identified for CSS) -> this is the same for the email input
There was a problem hiding this comment.
Hi Poonam, Thank you for reviewing my code. I did some changes based on the feedback... Looking forward to receive the reply
Poonam-raj
left a comment
There was a problem hiding this comment.
Good work - just add the name and id fields into the form. I would also format the code so the indenting is correct as currently the code is indented a bit randomly.
Do it manually, or you can use a code formatter like Prettier to format code for you if need be
| <p>Choose a T‑shirt colour:</p> | ||
|
|
||
| <label> | ||
| <input type="radio" name="colour" value="red" required> | ||
| Red | ||
| </label> | ||
|
|
||
| <label> | ||
| <input type="radio" name="colour" value="blue"> | ||
| Blue | ||
| </label> | ||
|
|
||
| <label> | ||
| <input type="radio" name="colour" value="black"> | ||
| Black | ||
| </label> |
There was a problem hiding this comment.
I would consider wrapping this in a <fieldset> tag to group the related inputs which are to do with colours
Poonam-raj
left a comment
There was a problem hiding this comment.
Last few bits to fix - sorry for the delay getting feedback back to you
Poonam-raj
left a comment
There was a problem hiding this comment.
Great work thanks for all the changes 🎉

Learners, PR Template
Self checklist
Changelist
I have completed all input fields based on the requirements. Validated all the code via validator.w3.org