Skip to content

Glasgow | 26-ITP-May | Lavanya Jayaprabu | Sprint 1 | Form Controls#1237

Open
Lavanya-Projects wants to merge 9 commits into
CodeYourFuture:mainfrom
Lavanya-Projects:feature/Form-Controls
Open

Glasgow | 26-ITP-May | Lavanya Jayaprabu | Sprint 1 | Form Controls#1237
Lavanya-Projects wants to merge 9 commits into
CodeYourFuture:mainfrom
Lavanya-Projects:feature/Form-Controls

Conversation

@Lavanya-Projects
Copy link
Copy Markdown

@Lavanya-Projects Lavanya-Projects commented May 8, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have completed all input fields based on the requirements. Validated all the code via validator.w3.org

Added a customer name input field
Added customer email input field
Added radio button for the colour selection
Added a dropdown section for the size selection
Added submit button, validate the input fields
@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit fc96998
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1011161027bf00084e879f
😎 Deploy Preview https://deploy-preview-1237--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Lavanya-Projects Lavanya-Projects added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@github-actions

This comment has been minimized.

@Lavanya-Projects Lavanya-Projects added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@Lavanya-Projects Lavanya-Projects added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 8, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Lavanya-Projects Lavanya-Projects added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@Lavanya-Projects Lavanya-Projects added the Module-Onboarding The name of the module. label May 8, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Lavanya-Projects Lavanya-Projects added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@Lavanya-Projects Lavanya-Projects added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@Lavanya-Projects Lavanya-Projects added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 8, 2026
@Poonam-raj Poonam-raj assigned Poonam-raj and unassigned Poonam-raj May 13, 2026
@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 13, 2026
@Poonam-raj Poonam-raj self-assigned this May 13, 2026
Comment thread Form-Controls/index.html Outdated
Comment on lines +17 to +18
<label>Customer Name: </label>
<input required minlength="2" pattern=".*\S.*\S.*">
Copy link
Copy Markdown
Contributor

@Poonam-raj Poonam-raj May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended to have id and name fields here (name field helps data be identified, id helps elements get identified for CSS) -> this is the same for the email input

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Poonam, Thank you for reviewing my code. I did some changes based on the feedback... Looking forward to receive the reply

Copy link
Copy Markdown
Contributor

@Poonam-raj Poonam-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - just add the name and id fields into the form. I would also format the code so the indenting is correct as currently the code is indented a bit randomly.

Do it manually, or you can use a code formatter like Prettier to format code for you if need be

@Poonam-raj Poonam-raj added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 15, 2026
@Lavanya-Projects Lavanya-Projects added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 16, 2026
Comment thread Form-Controls/index.html
Comment thread Form-Controls/index.html Outdated
Comment on lines +28 to +43
<p>Choose a T‑shirt colour:</p>

<label>
<input type="radio" name="colour" value="red" required>
Red
</label>

<label>
<input type="radio" name="colour" value="blue">
Blue
</label>

<label>
<input type="radio" name="colour" value="black">
Black
</label>
Copy link
Copy Markdown
Contributor

@Poonam-raj Poonam-raj May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider wrapping this in a <fieldset> tag to group the related inputs which are to do with colours

Comment thread Form-Controls/index.html Outdated
Comment thread Form-Controls/index.html Outdated
Copy link
Copy Markdown
Contributor

@Poonam-raj Poonam-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few bits to fix - sorry for the delay getting feedback back to you

@Poonam-raj Poonam-raj removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label May 20, 2026
@Lavanya-Projects Lavanya-Projects added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 22, 2026
@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 22, 2026
Copy link
Copy Markdown
Contributor

@Poonam-raj Poonam-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks for all the changes 🎉

@Poonam-raj Poonam-raj added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants