Skip to content

Cape Town | 26-ITP-Sept | Lamla Kamana | Sprint 3 | Coursework/sprint 3 - #1615

Open
lamlakamana-oss wants to merge 24 commits into
CodeYourFuture:mainfrom
lamlakamana-oss:coursework/sprint-3
Open

lamlakamana-oss wants to merge 24 commits into
CodeYourFuture:mainfrom
lamlakamana-oss:coursework/sprint-3

Conversation

@lamlakamana-oss

Copy link
Copy Markdown

Self checklist

  • [x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the style guide

Task Code

CYF-1053

Completed all mandatory and stretch tasks for Sprint 3.

Fixed bugs in the debugging exercises.

Implemented the toPounds function.

Added edge case tests for the time format exercise.

I agree to follow the code of conduct for this organisation

@netlify

netlify Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit b2459ed
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6abf85856c8ffe0008a679e8
😎 Deploy Preview https://deploy-preview-1615--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@lamlakamana-oss lamlakamana-oss added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 30, 2026
@Dilangi
Dilangi self-requested a review September 30, 2026 15:28
@Dilangi Dilangi added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Sep 30, 2026
@Dilangi

Dilangi commented Sep 30, 2026

Copy link
Copy Markdown

Hi Lamla, thanks for submitting this. Before the code feedback, a note on the PR itself.

PR title
It's a best practice to use a consistent title format so PRs are easy to track, search and review later. Suggested format:
Region | Cohort | FirstName LastName | Sprint | Assignment Title
Cohort: 25-ITP-Sep

PR description
Please add a "Change list" section before listing down what you changed.

Example:

Change list

You can edit the title and description at any time from the PR page.

@lamlakamana-oss lamlakamana-oss changed the title Cape Town | ITP-SEPT-2026 | Lamla Kamana | Sprint 3 | Coursework/sprint 3 Cape Town | 26-ITP-SEPT | Lamla Kamana | Sprint 3 | Coursework/sprint 3 Sep 30, 2026
@lamlakamana-oss lamlakamana-oss changed the title Cape Town | 26-ITP-SEPT | Lamla Kamana | Sprint 3 | Coursework/sprint 3 Cape Town | 26-ITP-Sept | Lamla Kamana | Sprint 3 | Coursework/sprint 3 Sep 30, 2026
Comment thread Sprint-3/1-key-errors/0.js
Comment thread Sprint-3/1-key-errors/1.js
Comment thread Sprint-3/1-key-errors/2.js
Comment thread Sprint-3/2-mandatory-debug/0.js Outdated
Comment thread Sprint-3/2-mandatory-debug/0.js
Comment thread Sprint-3/2-mandatory-debug/1.js
Comment thread Sprint-3/2-mandatory-debug/2.js
Comment thread Sprint-3/3-mandatory-implement/1-bmi.js Outdated
Comment thread Sprint-3/3-mandatory-implement/1-bmi.js
Comment thread Sprint-3/3-mandatory-implement/2-cases.js
Comment thread Sprint-3/3-mandatory-implement/3-to-pounds.js Outdated
Comment thread Sprint-3/3-mandatory-implement/3-to-pounds.js
Comment thread Sprint-3/4-mandatory-interpret/time-format.js
Comment thread Sprint-3/5-stretch-extend/format-time.js
@Dilangi Dilangi added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants