London | 26-ITP-Sept | Maharit Belai | Sprint 2 | Course work by MaharitB · Pull Request #1549 · CodeYourFuture/Module-JavaScript-Fundamentals

MaharitB · 2026-09-20T02:03:40Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1039

Changelist

I have created a new pull request based on the instruction left on the comment section

Questions

… the strings

…ng User

…ated as a string

netlify · 2026-09-20T02:03:45Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`ca1cf85`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab055ab21fe83000829ede8
😎 Deploy Preview	https://deploy-preview-1549--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

abdishakoor-dev

Thanks for redoing the branch, it is clean now.

There are some issues to fix here:

2-mandatory-errors/1.js, 2.js and 4.js all still stop with an error when you run them. See my comment on each.
1-key-exercises/3-paths.js, see my comment.
1-key-exercises/4-random.js, see my comment.
3-mandatory-interpret/1-percentage-change.js answer a), see my comment.
3-mandatory-interpret/2-time-format.js line 1 has been changed from the original, see my comment.
3-mandatory-interpret/2-time-format.js answers b) and f), see my comment.
Could you run Prettier over the Sprint-2 folder? Six of the files are not formatted at the moment.

Add the Needs Review label again when you have pushed.

abdishakoor-dev · 2026-09-20T08:25:08Z

@@ -2,3 +2,4 @@

 const age = 33;
 age = age + 1;


Your explanation on line 5 is right. Run the file though. It still stops with the same error, because line 3 is still const. This section wants the code fixed as well as explained.

Done! Thank you.

abdishakoor-dev · 2026-09-20T08:25:09Z

@@ -3,3 +3,4 @@

 console.log(`I was born in ${cityOfBirth}`);
 const cityOfBirth = "Bolton";


Your explanation on line 6 is right. This file still stops when you run it though. What would you move, so that line 4 prints "I was born in Bolton"?

abdishakoor-dev · 2026-09-20T08:25:09Z

@@ -1,2 +1,4 @@
 const 12HourClockTime = "8:53pm";


You are right about why this happens. Both names are still here though, so node cannot read the file at all. What would you rename them to?

The file runs now, good. Line 2 now says "20:53pm", but the original was "20:53". A 24-hour time does not use pm. Please put the original value back.

The two names are also the same apart from a capital H. Could you pick names that show which clock is which?

abdishakoor-dev · 2026-09-20T08:25:09Z

-
-// https://www.google.com/search?q=slice+mdn
+const startDirIndex = filePath.lastIndexOf("Users");
+const dir = filePath.slice(startDirIndex, lastSlashIndex);


Run this file and look at the dir line. It prints Users/mitch/... but the path starts with a /, so one character is missing. Two things to think about. Which index does lastIndexOf("Users") give you? And what happens to this code if the path does not contain the word Users at all? Your ext on lines 9 and 10 is a good example of the approach that would work here.

My first thought was that on the image "/ " was under the root and the dir starts from "home".
so, that is why I considered dropping the "/". But now I have fixed it.

abdishakoor-dev · 2026-09-20T08:25:09Z

+//num represents a number
+//lets start by (maximum-minimum +1) which the output is 100.
+//math.random()*100 returns random number between 0 and 100
+//math.floor()it rounds a number to thier nearest integer,


What does Math.floor(4.6) give you? And what does Math.round(4.6) give you? One of them rounds to the nearest whole number and the other does something else. Also, line 6 says num represents "a number". Can you be more exact about which numbers it can be?

Math.floor(4.6) gives me the the largest integer between 4 and 4.6which is 4.
Math.round(4.6) always return a value between 0 and 1 that is decimal number. even if any value is provided for the method.

Math.floor(4.6) is 4, you are right. But Math.round(4.6) is 5. Try it in node. The one that gives a number between 0 and 1 is Math.random().

So which one rounds to the nearest whole number? Line 11 still says Math.floor does.

Also line 6. What is the smallest value num can be? What is the largest?

abdishakoor-dev · 2026-09-20T08:25:09Z

-// d) Identify all the lines that are variable declarations
-
-// e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
+        // There are two function calls. line 4 and 5


You have found the two lines, but the question asks how many function calls there are. Line 4 has two of them, one inside the other. What is Number(...) doing there, and what is replaceAll(...) doing? Then look at line 10 as well.

abdishakoor-dev · 2026-09-20T08:25:09Z

@@ -1,4 +1,4 @@
-const movieLength = 8784; // length of movie in seconds
+const movieLength = 3000; // length of movie in seconds


This was 8784 in the original. Trying another value is the right instinct, but put the original back. The program you are explaining should be the one you were given.

abdishakoor-dev · 2026-09-20T08:25:09Z

+//A.There are six variable declararions

-// d) Interpret line 4, what does the expression assigned to totalMinutes mean?
+//B. no function calls


b) says there are no function calls. Have a look at line 10. What is console.log(...) doing there?

And on f) at line 29: you say you tried various values. Try 59, then -60, then 90.5. What does each one print? Would you show a time that way?

b) is right now.

For f), you say negative numbers and decimals do not work. What does the program print for -60? And for 90.5? Write one of those outputs in your answer, so it shows what goes wrong.

abdishakoor-dev · 2026-09-20T10:47:06Z

Ignore point 5 on my review, about putting movieLength back to 8784. Question f) asks you to try different values, so changing that line is what it wants. Everything else on the list still stands.

abdishakoor-dev

Thanks for the changes. 1.js, 2.js and 4.js all run now, and the dir line in 3-paths.js is right.

A few things are still open:

1-key-exercises/4-random.js lines 6 and 11, see my reply on that thread.
2-mandatory-errors/4.js line 2, see my reply on that thread.
3-mandatory-interpret/2-time-format.js answer f), see my reply on that thread.
Prettier still flags 2-mandatory-errors/0.js. Please format that file.

Add the Needs Review label again when you have pushed.

MaharitB added 26 commits September 20, 2026 02:32

untill i do this commit the work wont git base wont run

05c3d45

add ${} in backticks to creat a template literal to get initials from…

a4bfc54

… the strings

add slice() that would rerturn the dir part of the path

686ac69

declared dotIndex to save the the index of the dot.

f44d3e1

declared a variable startDirIndex to save the start index of the stri…

f5f7707

…ng User

delet content of slice()and replaced it to StartDirIndex

e1dda9e

delet 2 notes from the 3-paths.js

02ff8cf

change colon to semicolon

6f81459

remove +1 from slice() to make the output include dot(.)

26b0b8b

delet all comment lines

3e10e6d

remove the comment lines

9a94c44

explain the expression in order of mathematical operation

0bd5e8c

wrote console.log() to see what the code is doing

1a1c60a

format document

4d06615

add a single line comment for both lines

4aa68ab

add a comment on why it produces error

2d26b97

add more to the comment

532b0fa

add comment an answer to a first given question

f91783b

write a console .log() to run the code

118a824

edit code by enclosing the number by double quote then it will be tre…

41c8775

…ated as a string

edit the comment and delet the comments that were previously there

726810c

add a coment on the error

ceffa2d

fix the error by putting , in the replaceall() and answer the questions

8b2dbc2

delet the question in the comment and edit my answer

c52de96

run the code and edit my answers

4072533

describ line by line code

b20c858

This comment has been minimized.

Sign in to view

MaharitB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

This comment has been minimized.

Sign in to view

MaharitB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

MaharitB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2026

abdishakoor-dev reviewed Sep 20, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 20, 2026

MaharitB added 15 commits September 20, 2026 19:14

changethe declaration const to let

56bebf5

changed cosole.log() after initialization of cityOfBirth const

b584bde

add console.log for the const HourClockTime

e63d651

add console.log for const hourClockTime and add pm after 20:53

6b3c6ec

run prettier

118d7c2

run prettier

3daf70a

Run Prettier

bd744ff

run prettier

27f9052

add at line 6 in the .lastIndexOf() "/"

36dd0c6

add comments to the comment section for further explanation

2582f53

run prettier

5da1022

edit my Answer in the comment section

8211642

change into original value of movieLength

3ab1fb2

edit my comment for further explantion

5a7447d

edit the comment section

ca1cf85

MaharitB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 20, 2026

abdishakoor-dev reviewed Sep 21, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026

		@@ -3,3 +3,4 @@

		console.log(`I was born in ${cityOfBirth}`);
		const cityOfBirth = "Bolton";

		@@ -1,4 +1,4 @@
		const movieLength = 8784; // length of movie in seconds
		const movieLength = 3000; // length of movie in seconds

Uh oh!

Conversation

MaharitB commented Sep 20, 2026

Learners, PR Template

Task code

Changelist

Questions

Uh oh!

netlify Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MaharitB Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev commented Sep 20, 2026

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Sep 20, 2026 •

edited

Loading

MaharitB Sep 20, 2026 •

edited

Loading