Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Course-work-2 - #1546
Open
MattCarolus10 wants to merge 69 commits into
Open
MattCarolus10 wants to merge 69 commits into
MattCarolus10 wants to merge 69 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MattCarolus10
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
MattCarolus10
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
MattCarolus10
force-pushed
the
coursework/sprint-2
branch
from
September 25, 2026 16:38
1aca2c1 to
9cbdc83
Compare
MattCarolus10
added
the
Needs Review
Comment on lines
+8
to
+12
| // "num" variable carries the result/value of the expressions evaluated. | ||
| // (maximum - minimum) workout the size of the range: 100 - 1 + 1 = 100 | ||
| // Math.floor() takes out all decimal and make them a whole number from 0 to 99. | ||
| // Math.random() gives a decimal from 0 up to just under 1 (0.9999999). | ||
| // + minimum add 1 to the expression at the end because it is decleared a variable. No newline at end of file |
There was a problem hiding this comment.
The revised explanation looks much better now. Just a few minor issues to fix further:
Math.random()inside the(... * ...)would be evaluated beforeMath.floor()outside of it. So it would be better to swap lines 10 and 11 in your explanation.+ minimumat the end is not because of "it is declared a variable". This final part has its own purpose in this program. Can you think of the purpose of adding minimum at the end?
Author
There was a problem hiding this comment.
Thank you so much, I have fixed all errors now.
|
Thanks for your updated code and so far looked good to me. You are almost there and now just remaining the following issues. Would you please fix them as well?
|
Author
|
I definitely will fix them. Thanks so much for reviewing my work
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: hackertainment ***@***.***>
Sent: Saturday, 26 September 2026 16:16:08
To: CodeYourFuture/Module-JavaScript-Fundamentals ***@***.***>
Cc: Mathew Shaibu ***@***.***>; Author ***@***.***>
Subject: Re: [CodeYourFuture/Module-JavaScript-Fundamentals] Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 2 | Course-work-2 (PR #1546)
[https://avatars.githubusercontent.com/u/259196870?s=20&v=4]hackertainment left a comment (CodeYourFuture/Module-JavaScript-Fundamentals#1546)<#1546 (comment)>
Thanks for your updated code and so far looked good to me. Now just remaining the following two issues. Would you please fix them as well?
* #1546 (comment)<#1546 (comment)>
* #1546 (comment)<#1546 (comment)> (I have also mentioned about rephrasing line 50-51, now 47-48, as well. The lines are listed below for reference.)
// The "substring(paddedPenceNumberString.length - 2)" function deducts 3 leaving the last two numbers 99
// PadEnd(2, "0") ensure the value remains 2 and 0 to be added to value less than 2.
—
Reply to this email directly, view it on GitHub<#1546?email_source=notifications&email_token=B4W43WLPJRRV4TVEEJ7MC535Q7MTRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOBUG4ZTQNZYGYYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5847387860>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B4W43WILRGTKXMNHK5FAZ7L5Q7MTRAVCNFSNUABFKJSXA33TNF2G64TZHM4DSOJQGI2DGMRUHNEXG43VMU5TKNJRGM2DCMRXGQ22C5QC>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/B4W43WIZQ7VOEVLKERHNXAT5Q7MTRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOBUG4ZTQNZYGYYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android<https://github.com/notifications/mobile/android/B4W43WOHUOFIWBPT2W35QXT5Q7MTRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKOBUG4ZTQNZYGYYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
hackertainment
removed
the
Needs Review
MattCarolus10
added
the
Needs Review
|
How about |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1039
Changelist
Questions
Most functions in this project are new to me, even though I have been able to understand their functions individually, I am not really confident to code with them. I will keep practicing and any advise would really be appreciated.